Skip to content

chore(test): add e2e tests for gitops-engine #23304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 17, 2025
Merged

chore(test): add e2e tests for gitops-engine #23304

merged 10 commits into from
Jun 17, 2025

Conversation

@agaudreault
Copy link
Member

@agaudreault agaudreault commented Jun 6, 2025

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@agaudreault
test gitops PR
5710f26 
Signed-off-by: Alexandre Gaudreault <[email protected]>
@bunnyshell
Copy link

bunnyshell bot commented Jun 6, 2025 •
edited
Loading

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@agaudreault agaudreault mentioned this pull request Jun 6, 2025
Merged
@agaudreault agaudreault changed the title WIP: test gitops PR chore: WIP: test gitops PR Jun 6, 2025
@agaudreault
Merge branch 'master' into test-gitops-pr-1
03191b3 
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault
fix go mod
2f01b8f 
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault agaudreault mentioned this pull request Jun 6, 2025
Closed
@codecov
Copy link

codecov bot commented Jun 6, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.06%. Comparing base (28e871e) to head (0bed9ec).
⚠️ Report is 436 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #23304      +/-   ##
==========================================
- Coverage   60.11%   60.06%   -0.06%     
==========================================
  Files         342      342              
  Lines       58820    58792      -28     
==========================================
- Hits        35359    35312      -47     
- Misses      20617    20627      +10     
- Partials     2844     2853       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agaudreault
add e2e
3de0803 
Signed-off-by: Alexandre Gaudreault <[email protected]>
agaudreault
agaudreault commented Jun 6, 2025
View reviewed changes
go.mod Outdated

go 1.24.4

replace github.com/argoproj/gitops-engine => github.com/agaudreault/gitops-engine v0.7.1-0.20250606141133-32f56cd438c3
Copy link
Member Author

@agaudreault agaudreault Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: revert when merge

agaudreault
agaudreault commented Jun 6, 2025
View reviewed changes
test/e2e/sync_options_test.go
// Then, --dest-namespace is created with server side apply
// application is synced and healthy with resource
// application resources created with server side apply in the newly created namespace.
func TestNamespaceCreationWithSSA(t *testing.T) {
Copy link
Member Author

@agaudreault agaudreault Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test was moved and not changed

Copy link
Member Author

@agaudreault agaudreault Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: test was updated because for some reason the e2e fails with error creating application: namespaces \"argocd-e2e-external\" not found which was not required for this test anyway.

@agaudreault
Merge remote-tracking branch 'upstream/master' into test-gitops-pr-1
dfa70ce 
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault
lint
34df8d9 
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault agaudreault added this to the v3.1 milestone Jun 6, 2025
@agaudreault
fix tests
16dd3b2 
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault
fix SSA test
a65b69d 
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault
Merge remote-tracking branch 'upstream/master' into test-gitops-pr-1
792cf82 
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault
update mod
0bed9ec 
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault agaudreault changed the title chore: WIP: test gitops PR chore(test): add e2e tests for gitops-engine Jun 16, 2025
@agaudreault agaudreault marked this pull request as ready for review June 16, 2025 21:32
@agaudreault agaudreault requested a review from a team as a code owner June 16, 2025 21:32
@agaudreault agaudreault enabled auto-merge (squash) June 16, 2025 21:33
@agaudreault agaudreault merged commit e25123b into argoproj:master Jun 17, 2025
29 checks passed
@yashuatla yashuatla mentioned this pull request Jun 25, 2025
Open
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
@agaudreault @enneitex
chore(test): add e2e tests for gitops-engine (argoproj#23304)
f9038d5 
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: enneitex <[email protected]>
Mangaal pushed a commit to Mangaal/argo-cd that referenced this pull request Sep 10, 2025
@agaudreault @Mangaal
chore(test): add e2e tests for gitops-engine (argoproj#23304)
12eaaaa 
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakepettersson blakepettersson blakepettersson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.1

Development

Successfully merging this pull request may close these issues.

2 participants

@agaudreault @blakepettersson