fix: linting pointer error when template name is invalid #14896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes argoproj#14861 We need to check if the template is nil before using it. If it is we return and give helpful message. Signed-off-by: jmeridth <[email protected]>
isubasinghe
approved these changes
Sep 30, 2025
Joibel
added
cherry-pick/3.6
|
❌ Cherry-pick failed for 3.7. Please check the workflow logs for details. |
|
❌ Cherry-pick failed for 3.6. Please check the workflow logs for details. |
Joibel
pushed a commit
that referenced
this pull request
Oct 21, 2025
(cherry picked from commit 4eb7b01) Signed-off-by: jmeridth <[email protected]> Signed-off-by: Alan Clucas <[email protected]>
This was referenced Oct 21, 2025
ItielOlenick
pushed a commit
to ItielOlenick/argo-workflows
that referenced
this pull request
Oct 26, 2025
) Signed-off-by: jmeridth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14861
Motivation
We need to check if the template is nil before using it. If it is we return and give helpful message.
Modifications
I moved the if check to check if the
tmpl(template) is nil before usage.I added a test to show that we don't currently consider empty steps to be a linting error, as mentioned in the issue. If we change our minds later we have a test that will break if so. 😄
Verification
Added linting test to the e2e tests for linting.
Documentation