fix: prevent nil pointer dereference in GetTemplateFromRef with podMetadata. Fixes #14968 #14970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tadata. Fixes argoproj#14968 Signed-off-by: Bjoern Weidlich <[email protected]>
Contributor
Author
|
@Joibel no problem. Marked this PR as ready for review |
|
❌ Cherry-pick failed for 3.7. Please check the workflow logs for details. |
Joibel
pushed a commit
that referenced
this pull request
Nov 11, 2025
…tadata. Fixes #14968 (#14970) (cherry picked from commit c9cba3b) Signed-off-by: Bjoern Weidlich <[email protected]> Signed-off-by: Alan Clucas <[email protected]>
Joibel
added a commit
that referenced
this pull request
Nov 11, 2025
…tadata. Fixes #14968 (cherry-pick #14970 for 3.7) (#15029) Signed-off-by: Bjoern Weidlich <[email protected]> Signed-off-by: Alan Clucas <[email protected]> Co-authored-by: Bjoern Weidlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14968
Motivation
I ran into this nil pointer due to malformed CronWorkflows and wanted to see if I could fix it.
Modifications
I made sure a nil check happened before that object was subsequently accessed in
addPodMetadata()Verification
I wrote a unit test to replicate the issue
Documentation
No update to documentation should be necessary as this simply fixes a bug.