-
Notifications
You must be signed in to change notification settings - Fork 6.5k
docs: Update Argo CD installation and API server access instructions #25120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
revitalbarletz
wants to merge
13
commits into
argoproj:master
Choose a base branch
from
revitalbarletz:patch-14
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3
−5
Open
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9c00915
Update Argo CD installation and API server access instructions
revitalbarletz 75b3965
Update docs/getting_started.md
revitalbarletz 1210901
Update docs/getting_started.md
revitalbarletz 037f1df
Merge branch 'master' into patch-14
revitalbarletz 387b3d8
Clarify access methods for Argo CD API server
revitalbarletz 150b1fa
Update getting_started.md
revitalbarletz 00eb3ab
Merge branch 'master' into patch-14
revitalbarletz e690a75
Merge branch 'master' into patch-14
revitalbarletz 59ffbeb
Update docs/getting_started.md
revitalbarletz fa716f7
Merge branch 'master' into patch-14
revitalbarletz 5a8f02d
Merge branch 'master' into patch-14
revitalbarletz 4b31f7d
Merge branch 'master' into patch-14
revitalbarletz 3acab47
Merge branch 'master' into patch-14
revitalbarletz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, it is the api-server tha makes more sense to be here. I would recommend adding a link to the architecture docs here. Just saying Argo CD means all the components can't be exposed outside the cluster whereas in reality, it's only one component of Argo CD i.e. api-server which is not exposed with an external IP.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should remain abstract and we should refer to Argo CD rather than Argo CD API - its a getting started guide and the component were not described yet here. It seems more of a high level document to me. @todaywasawesome / @crenshaw-dev what do you think?