Skip to content

Conversation

@revitalbarletz
Copy link
Contributor

@revitalbarletz revitalbarletz commented Oct 30, 2025

Clarified installation instructions for Argo CD and updated section title for API server access.

Fixes issue #24540

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Clarified installation instructions for Argo CD and updated section title for API server access.

Signed-off-by: Revital Barletz <[email protected]>
@revitalbarletz revitalbarletz requested review from a team as code owners October 30, 2025 14:07
@bunnyshell
Copy link

bunnyshell bot commented Oct 30, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@revitalbarletz revitalbarletz changed the title Update Argo CD installation and API server access instructions (docs) update Argo CD installation and API server access instructions Oct 30, 2025
@revitalbarletz revitalbarletz changed the title (docs) update Argo CD installation and API server access instructions docs: update Argo CD installation and API server access instructions Oct 30, 2025
@revitalbarletz revitalbarletz changed the title docs: update Argo CD installation and API server access instructions docs: Update Argo CD installation and API server access instructions Oct 30, 2025
revitalbarletz and others added 4 commits October 31, 2025 14:36
Co-authored-by: Dan Garfield <[email protected]>
Signed-off-by: Revital Barletz <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>
Signed-off-by: Revital Barletz <[email protected]>
Reworded the explanation for accessing the Argo CD API server to clarify that it isn't exposed outside the cluster.

Signed-off-by: Revital Barletz <[email protected]>
@revitalbarletz
Copy link
Contributor Author

@todaywasawesome I changed the text as well either, can you take another look please?

revitalbarletz and others added 2 commits November 4, 2025 10:48
@revitalbarletz
Copy link
Contributor Author

@crenshaw-dev & @todaywasawesome please review again. Thank you!

By default, the Argo CD API server is not exposed with an external IP. To access the API server,
choose one of the following techniques to expose the Argo CD API server:
By default, Argo CD isn’t exposed outside the cluster. To access Argo CD from your browser or CLI, use one of the following methods:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, it is the api-server tha makes more sense to be here. I would recommend adding a link to the architecture docs here. Just saying Argo CD means all the components can't be exposed outside the cluster whereas in reality, it's only one component of Argo CD i.e. api-server which is not exposed with an external IP.

Copy link
Contributor Author

@revitalbarletz revitalbarletz Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should remain abstract and we should refer to Argo CD rather than Argo CD API - its a getting started guide and the component were not described yet here. It seems more of a high level document to me. @todaywasawesome / @crenshaw-dev what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants