-
Notifications
You must be signed in to change notification settings - Fork 6.5k
docs: Update Argo CD installation and API server access instructions #25120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Clarified installation instructions for Argo CD and updated section title for API server access. Signed-off-by: Revital Barletz <[email protected]>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Revital Barletz <[email protected]>
Co-authored-by: Dan Garfield <[email protected]> Signed-off-by: Revital Barletz <[email protected]>
Reworded the explanation for accessing the Argo CD API server to clarify that it isn't exposed outside the cluster. Signed-off-by: Revital Barletz <[email protected]>
|
@todaywasawesome I changed the text as well either, can you take another look please? |
Signed-off-by: Revital Barletz <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Revital Barletz <[email protected]>
|
@crenshaw-dev & @todaywasawesome please review again. Thank you! |
| By default, the Argo CD API server is not exposed with an external IP. To access the API server, | ||
| choose one of the following techniques to expose the Argo CD API server: | ||
| By default, Argo CD isn’t exposed outside the cluster. To access Argo CD from your browser or CLI, use one of the following methods: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, it is the api-server tha makes more sense to be here. I would recommend adding a link to the architecture docs here. Just saying Argo CD means all the components can't be exposed outside the cluster whereas in reality, it's only one component of Argo CD i.e. api-server which is not exposed with an external IP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should remain abstract and we should refer to Argo CD rather than Argo CD API - its a getting started guide and the component were not described yet here. It seems more of a high level document to me. @todaywasawesome / @crenshaw-dev what do you think?
Clarified installation instructions for Argo CD and updated section title for API server access.
Fixes issue #24540
Checklist: