fix(server): ensure resource health status is inferred on application retrieval (#24832) #24851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
… retrieval (argoproj#24832) Before this patch when calling GetApplication with refresh=true, the Application.Status.Resources[].Health field was not populated with health statuses from the ApplicationTree cache, as it should be just like when calling without refresh. Signed-off-by: Viacheslav Rianov <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24851 +/- ##
==========================================
+ Coverage 60.78% 60.79% +0.01%
==========================================
Files 404 404
Lines 66232 66233 +1
==========================================
+ Hits 40256 40266 +10
+ Misses 22730 22723 -7
+ Partials 3246 3244 -2 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
added
cherry-pick/3.0
argo-cd-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Oct 6, 2025
… retrieval (#24832) (#24851) Signed-off-by: Viacheslav Rianov <[email protected]>
argo-cd-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Oct 6, 2025
… retrieval (#24832) (#24851) Signed-off-by: Viacheslav Rianov <[email protected]>
|
🍒 Cherry-pick PR created for 3.2: #24865 |
argo-cd-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Oct 6, 2025
… retrieval (#24832) (#24851) Signed-off-by: Viacheslav Rianov <[email protected]>
|
🍒 Cherry-pick PR created for 3.0: #24866 |
|
🍒 Cherry-pick PR created for 3.1: #24867 |
|
❌ Cherry-pick failed for 2.14. Please check the workflow logs for details. |
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 6, 2025
… retrieval (#24832) (cherry-pick #24851 for 3.2) (#24865) Signed-off-by: Viacheslav Rianov <[email protected]> Co-authored-by: Rianov Viacheslav <[email protected]>
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 6, 2025
… retrieval (#24832) (cherry-pick #24851 for 3.1) (#24867) Signed-off-by: Viacheslav Rianov <[email protected]> Co-authored-by: Rianov Viacheslav <[email protected]>
|
@vr009 the cherry-picks for 2.14 and 3.0 failed. If you'd like this patched back on those versions, could you please open a manual PR against the release-2.14 and release-3.0 branches respectively? |
Sure, I’ll take care of it |
vr009
added a commit
to vr009/argo-cd
that referenced
this pull request
Oct 12, 2025
… retrieval (argoproj#24832) (argoproj#24851) Signed-off-by: Viacheslav Rianov <[email protected]> (cherry picked from commit 7430650)
14 tasks
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 14, 2025
… retrieval (#24832) (cherry-pick #24851 for 3.0) (#24945) Signed-off-by: Viacheslav Rianov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch when calling GetApplication with refresh=true, the Application.Status.Resources[].Health field was not populated with health statuses from the ApplicationTree cache, as it should be just like when calling without refresh.
This patch might be cherry-picked into all related 3.x versions as well
Fixes #24832
Checklist: