feat: add status.resourcesCount field to appset and change limit default #24698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
| // Resources is a list of Applications resources managed by this application set. | ||
| Resources []ResourceStatus `json:"resources,omitempty" protobuf:"bytes,3,opt,name=resources"` | ||
| Resources []ResourceStatus `json:"resources,omitempty" protobuf:"bytes,3,opt,name=resources"` | ||
| ResourcesCount int64 `json:"resourcesCount,omitempty" protobuf:"varint,4,opt,name=resourcesCount"` |
There was a problem hiding this comment.
Should have a docstring for this, particularly to explain it may differ from the actual length of resources.
There was a problem hiding this comment.
Makes sense. Added documentation
Signed-off-by: Alexander Matyushentsev <[email protected]>
alexmt
force-pushed
the
resource-limit-default
branch
from
6f5cdf9 to
9d76def
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24698 +/- ##
==========================================
- Coverage 60.51% 60.48% -0.04%
==========================================
Files 350 350
Lines 60196 60199 +3
==========================================
- Hits 36430 36411 -19
- Misses 20832 20849 +17
- Partials 2934 2939 +5 ☔ View full report in Codecov by Sentry. |
|
thanks for review @crenshaw-dev PTAL |
crenshaw-dev
approved these changes
Sep 23, 2025
alexmt
added
the
cherry-pick/3.2
|
❌ Cherry-pick failed for 3.2. Please check the workflow logs for details. |
alexmt
added a commit
to alexmt/argo-cd
that referenced
this pull request
Sep 23, 2025
…ult (argoproj#24698) Signed-off-by: Alexander Matyushentsev <[email protected]>
alexmt
added a commit
that referenced
this pull request
Sep 24, 2025
…ult (#24698) (#24711) Signed-off-by: Alexander Matyushentsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is a followup for #24690
It changes the default limit of number of resources stored in applicationset status to 5000.
Also adds
resourcesCountfield to help building future applicationset UI that will show appset resources tree.