fix: limit number of resources in appset status

[alexmt]

Closes #24689

The applicationSet.status.resources is meant for appset visualization in a future UI/CLI. However it limits the number of applications that can be managed by a single appset.

The desire to build UI should not limit core functionality of application set. From experience of building application tree visualization we know that 1000+ resources is already hard to scale. So in this PR I'm proposing to introduce ARGOCD_APPLICATIONSET_CONTROLLER_MAX_RESOURCES_STATUS_COUNT that limits number of resources stored in status (5k by default). So this way appset can generate any number of apps and in a future UI we can add a warning that only first 5k is shown.

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[nitishfy]

Thank you! The changes looks good to me. Few points:

1. Can you please add unit test here?
2. The lint check is failing that needs to be fixed.

[alexmt]

Thanks for looking at PR @nitishfy !

• Can you please add unit test here?
  This is already done: https://github.com/argoproj/argo-cd/pull/24690/files#diff-88fec9c8d881ff513bb04ee8842efcc4f0db0ec0ce631fec3f730633a91ebea6R6137

• The lint check is failing that needs to be fixed.
  Fixes - thank you!

[crenshaw-dev]

Should we have a condition to indicate the truncation to the user/UI?

[alexmt]

Thanks for review @crenshaw-dev !

Should we have a condition to indicate the truncation to the user/UI?

I was thinking about too while writing PR description. Added status.resourcesCount with the number of resources before truncation. This way UI warning can have e.g. `Warning: 100 more applications are hidden" .

[crenshaw-dev]

Probably wants a doc string so the future UI dev knows how to use this.

Are you hoping to cherry-pick the change back? I think for 3.2 it would be fine, but adding a CRD field further back feels maybe not great.

[alexmt]

ah, you are right. What do you think about adding resourcesCount in a separate PR? The UI functionality is not ready yet, so we are not loosing anything without resourcesCount. We can cherry-pick first PR into previous release and resourcesCount can go only to master branch.

[alexmt]

I've moved change to a separate commit: d5e690f . If you are fine with it, I will create new PR as soon as this one merged.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.52%. Comparing base (f960274) to head (315d022).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #24690      +/-   ##
==========================================
+ Coverage   60.46%   60.52%   +0.06%     
==========================================
  Files         350      350              
  Lines       60187    60196       +9     
==========================================
+ Hits        36390    36434      +44     
+ Misses      20859    20827      -32     
+ Partials     2938     2935       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[argo-cd-cherry-pick-bot]

❌ Cherry-pick failed for 3.1. Please check the workflow logs for details.

[argo-cd-cherry-pick-bot]

❌ Cherry-pick failed for 3.0. Please check the workflow logs for details.

[argo-cd-cherry-pick-bot]

❌ Cherry-pick failed for 3.2. Please check the workflow logs for details.

[argo-cd-cherry-pick-bot]

❌ Cherry-pick failed for 2.14. Please check the workflow logs for details.