-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore: Use watch APIs for listing resources (#22499) #22926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: Use watch APIs for listing resources (#22499) #22926
Conversation
❌ Preview Environment undeployed from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
dc38a98 to
f7b18a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22926 +/- ##
==========================================
- Coverage 60.03% 60.00% -0.04%
==========================================
Files 344 343 -1
Lines 57781 57792 +11
==========================================
- Hits 34689 34678 -11
- Misses 20333 20342 +9
- Partials 2759 2772 +13 ☔ View full report in Codecov by Sentry. |
|
QQ: Would this be relevant with K8s 1.33, since it seems like streaming list responses will "just work" OOTB? EDIT: The feature above is for the API server itself, and has no bearing on what the client does. Never mind! |
|
Related to argoproj/gitops-engine#716 |
|
Enable k8s 1.33 in e2e tests so we test more than just the fallback behavior? |
Signed-off-by: Michael Crenshaw <[email protected]>
|
Seems like it's enabled at least partially in 1.32, but yeah, 1.33 is better. https://kubernetes.io/blog/2024/12/17/kube-apiserver-api-streaming/#what-s-next |
|
FYI, I havent followed much, but 1.33 is not merged in argo #23362 |
Helps with #22499
Use WatchListClient feature which together with Gitops Engine changes would try to use Watch APIs for List Resources and fallback to the regular method if it's not available (e.g. Kubernetes doesn't have it enabled by default for versions <= 1.31).
Checklist: