Skip to content

Conversation

@andrii-korotkov
Copy link
Contributor

@andrii-korotkov andrii-korotkov commented May 11, 2025

Helps with #22499

Use WatchListClient feature which together with Gitops Engine changes would try to use Watch APIs for List Resources and fallback to the regular method if it's not available (e.g. Kubernetes doesn't have it enabled by default for versions <= 1.31).

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@andrii-korotkov andrii-korotkov requested a review from a team as a code owner May 11, 2025 23:02
@bunnyshell
Copy link

bunnyshell bot commented May 11, 2025

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@andrii-korotkov andrii-korotkov marked this pull request as draft May 11, 2025 23:02
@andrii-korotkov andrii-korotkov force-pushed the 22499-use-watch-apis-for-list-resources branch from dc38a98 to f7b18a3 Compare May 11, 2025 23:16
@codecov
Copy link

codecov bot commented May 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.00%. Comparing base (610523b) to head (64f79b9).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22926      +/-   ##
==========================================
- Coverage   60.03%   60.00%   -0.04%     
==========================================
  Files         344      343       -1     
  Lines       57781    57792      +11     
==========================================
- Hits        34689    34678      -11     
- Misses      20333    20342       +9     
- Partials     2759     2772      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blakepettersson
Copy link
Member

blakepettersson commented May 12, 2025

QQ: Would this be relevant with K8s 1.33, since it seems like streaming list responses will "just work" OOTB?

EDIT: The feature above is for the API server itself, and has no bearing on what the client does. Never mind!

@blakepettersson
Copy link
Member

Related to argoproj/gitops-engine#716

@crenshaw-dev
Copy link
Member

Enable k8s 1.33 in e2e tests so we test more than just the fallback behavior?

Signed-off-by: Michael Crenshaw <[email protected]>
@andrii-korotkov
Copy link
Contributor Author

Seems like it's enabled at least partially in 1.32, but yeah, 1.33 is better.

https://kubernetes.io/blog/2024/12/17/kube-apiserver-api-streaming/#what-s-next

@crenshaw-dev crenshaw-dev added this to the v3.1 milestone May 21, 2025
@agaudreault agaudreault modified the milestones: v3.1, v3.2 Jun 12, 2025
@agaudreault
Copy link
Member

FYI, I havent followed much, but 1.33 is not merged in argo #23362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants