Skip to content

Conversation

@sivchari
Copy link
Member

@sivchari sivchari commented Apr 29, 2025

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Currently, isCanceledContextErr can only handle the context.Canceled and gRPC status when the communication is hung up. So if first communication is succeeded, then second communication passed context that has already been deadline exceeded, the loop is no longer break since the context.DeadlineExceeded isn't considered. So I made it consider the context.DeadlineExceeded.

@sivchari sivchari requested a review from a team as a code owner April 29, 2025 13:02
@bunnyshell
Copy link

bunnyshell bot commented Apr 29, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.11%. Comparing base (db9c82a) to head (eb78ade).
⚠️ Report is 632 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiclient/apiclient.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22824      +/-   ##
==========================================
+ Coverage   56.06%   56.11%   +0.04%     
==========================================
  Files         343      343              
  Lines       57545    57545              
==========================================
+ Hits        32262    32289      +27     
+ Misses      22633    22612      -21     
+ Partials     2650     2644       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev
Copy link
Member

@sivchari is this something we could test? Obviously we could unit test the function, but something more end-to-end would be nice if possible.

@sivchari
Copy link
Member Author

@crenshaw-dev
This bug was found while working on #21963 .

The following 2 test has already tested this function on e2e, then these are sometime stuck since the deadline doesn't be handled. I tried to reproduce on my machine, but it's difficult to reproduce since this failure is important for timing.
IMO, it's good to check on ut. What do you think ?

@sivchari sivchari requested a review from crenshaw-dev May 16, 2025 04:47
@sivchari sivchari self-assigned this May 16, 2025
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @crenshaw-dev are we good to merge this?

@crenshaw-dev crenshaw-dev merged commit 61b3ea1 into argoproj:master Jun 8, 2025
28 checks passed
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants