feat: Refactor about the way to use context.TODO and context.Background #21963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Preview Environment undeploy from Bunnyshell failedSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21963 +/- ##
==========================================
+ Coverage 56.06% 56.07% +0.01%
==========================================
Files 343 343
Lines 57545 57573 +28
==========================================
+ Hits 32262 32286 +24
- Misses 22633 22645 +12
+ Partials 2650 2642 -8 ☔ View full report in Codecov by Sentry. |
sivchari
force-pushed
the
refactor-ctx
branch
from
51cca73 to
3434bcc
Compare
sivchari
force-pushed
the
refactor-ctx
branch
2 times, most recently
from
87862b8 to
a7a71f9
Compare
sivchari
changed the title
This was referenced Apr 20, 2025
sivchari
force-pushed
the
refactor-ctx
branch
4 times, most recently
from
db4446c to
80f6145
Compare
sivchari
force-pushed
the
refactor-ctx
branch
10 times, most recently
from
d293908 to
262e38b
Compare
sivchari
commented
Apr 21, 2025
Comment on lines
+296
to
+297
| github.com/argoproj/gitops-engine => github.com/sivchari/gitops-engine v0.0.0-20250421124833-45bcf5629986 | ||
| github.com/argoproj/notifications-engine => github.com/sivchari/notifications-engine v0.0.0-20250420144357-6843172f87f1 |
There was a problem hiding this comment.
It should be replaced before this PR is merged.
sivchari
force-pushed
the
refactor-ctx
branch
3 times, most recently
from
8be83f1 to
e3d4897
Compare
|
Hi @crenshaw-dev |
|
@gdsoumya @blakepettersson PTAL 🙏 |
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
sivchari
force-pushed
the
refactor-ctx
branch
3 times, most recently
from
7d46ef1 to
64c1c05
Compare
Signed-off-by: sivchari <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #21942
Until now, we have logics not to pass context, but was using context.Background or context.TODO. This isn't best practice for Go since if the context isn't passed, the logics are out of control of cancellation. By propagating context correctly makes some advantages. At first, we can cancel all goroutines and some requests (e.g. Git, Helm and http client etc). This can avoid goroutine leaks, so the machine doesn't remain extra cpu and memory. Next, our interfaces are enable to define context at first params surely. This practice makes good impact in the future development.
I think the most concerning is that some interface are changed, so if you have some opinion, let me know about it. Please join us with discussion to improve Argo CD.
Checklist: