Skip to content

feat: update the kubernetes version to 1.33.0 #22822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

feat: update the kubernetes version to 1.33.0 #22822

wants to merge 16 commits into from

Conversation

@chansuke
Copy link
Contributor

@chansuke chansuke commented Apr 29, 2025 •
edited
Loading

Closes #22805

  • go version update
  • Kubernetes dependencies update

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell
Copy link

bunnyshell bot commented Apr 29, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@chansuke chansuke changed the title chore: update the kubrnetes version to 1.3.3 chore: update the kubrnetes version to 1.33.0 Apr 29, 2025
nitishfy
nitishfy reviewed Apr 29, 2025
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR ready for review?

@chansuke
Copy link
Contributor Author

chansuke commented Apr 29, 2025

@nitishfy
Thank you for your comment.wip now.

@chansuke chansuke force-pushed the update-kubrnetes-v1_33 branch from 6b789b9 to 5b4fbbb Compare April 29, 2025 15:19
@codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@0e95193). Learn more about missing BASE report.
⚠️ Report is 478 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #22822   +/-   ##
=========================================
  Coverage          ?   60.09%           
=========================================
  Files             ?      341           
  Lines             ?    57868           
  Branches          ?        0           
=========================================
  Hits              ?    34776           
  Misses            ?    20324           
  Partials          ?     2768

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chansuke chansuke marked this pull request as ready for review April 30, 2025 00:53
@chansuke chansuke requested a review from a team as a code owner April 30, 2025 00:53
@chansuke chansuke requested a review from nitishfy April 30, 2025 00:53
@sivchari
Copy link
Member

sivchari commented Apr 30, 2025 •
edited
Loading

if it's the time when it's ready for review, please let me know.

@chansuke
Copy link
Contributor Author

chansuke commented Apr 30, 2025

@nitishfy @sivchari
please take a look when you have a moment.

sivchari
sivchari reviewed Apr 30, 2025
View reviewed changes
Copy link
Member

@sivchari sivchari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update controller-runtime to v0.20.4, then also upgrade Kubernetes matrix version in GHA. Here is the line you should edit
https://github.com/argoproj/argo-cd/blob/master/.github/workflows/ci-build.yaml#L407

k3s prepares release for v1.33.0 in it, so we just wait until the new release is launched.

go.mod Outdated
k8s.io/kube-scheduler => k8s.io/kube-scheduler v0.33.0
k8s.io/kubectl => k8s.io/kubectl v0.33.0
k8s.io/kubelet => k8s.io/kubelet v0.33.0
k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.32.2
Copy link
Member

@sivchari sivchari Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.32.2

It looks like it doesn't use in any place anymore. It's good time to delete it, then the dependency is incorrect since the latest version is v0.30.12 now.

Copy link
Contributor Author

@chansuke chansuke Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your comment! I'll remove it:)

@chansuke
Copy link
Contributor Author

chansuke commented Apr 30, 2025

@sivchari
I appreciate for your review and comment!

k3s prepares release for v1.33.0 in it, so we just wait until the new release is launched.

Ohh, thanks. I will wait for that. It surely about to release :)

todaywasawesome
todaywasawesome requested changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! To complete the CI tests need to be added for 1.33. See this PR for example. #21805

@chansuke
Copy link
Contributor Author

chansuke commented Apr 30, 2025

@todaywasawesome
Thanks!!

@chansuke chansuke changed the title chore: update the kubrnetes version to 1.33.0 feat: update the kubrnetes version to 1.33.0 May 1, 2025
@chansuke chansuke force-pushed the update-kubrnetes-v1_33 branch from 1311d0a to 420101e Compare May 10, 2025 14:20
@chansuke chansuke requested a review from a team as a code owner May 10, 2025 14:20
@chansuke chansuke force-pushed the update-kubrnetes-v1_33 branch from 420101e to e89c46c Compare May 10, 2025 14:22
@chansuke chansuke requested a review from a team as a code owner May 10, 2025 15:01
@chansuke chansuke force-pushed the update-kubrnetes-v1_33 branch from d9dbf56 to e3ec629 Compare May 10, 2025 16:19
sivchari
sivchari reviewed May 12, 2025
View reviewed changes
go.mod
Copy link
Member

@sivchari sivchari May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also wait that new controller-runtime is launched since 0.20 doesn't use v1.33.0

@chansuke
fix: remove v1.29.8
8589d2a 
Signed-off-by: chansuke <[email protected]>
@chansuke chansuke force-pushed the update-kubrnetes-v1_33 branch from c0cbc99 to 8589d2a Compare May 13, 2025 13:14
@crenshaw-dev
Copy link
Member

crenshaw-dev commented May 21, 2025

@sivchari should this be updated to point to your gitops-engine PR here? argoproj/gitops-engine#717

@crenshaw-dev crenshaw-dev changed the title feat: update the kubrnetes version to 1.33.0 feat: update the kubernetes version to 1.33.0 May 23, 2025
@chansuke chansuke force-pushed the update-kubrnetes-v1_33 branch from af1e081 to 6962dc5 Compare May 24, 2025 01:37
@chansuke chansuke requested a review from sivchari May 24, 2025 02:35
@crenshaw-dev crenshaw-dev added this to the v3.1 milestone May 28, 2025
andrii-korotkov
andrii-korotkov approved these changes Jun 13, 2025
View reviewed changes
pkg/client/informers/externalversions/application/v1alpha1/appproject.go
}
return client.ArgoprojV1alpha1().AppProjects(namespace).List(ctx, options)
},
WatchFuncWithContext: func(ctx context.Context, options v1.ListOptions) (watch.Interface, error) {
Copy link
Contributor

@andrii-korotkov andrii-korotkov Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to add these?

@andrii-korotkov andrii-korotkov added the ready-for-review An approver should give a final review and merge the PR label Jun 13, 2025
@github-project-automation github-project-automation bot moved this to Ready for final review in Argo CD Review Jun 13, 2025
agaudreault
agaudreault requested changes Jun 13, 2025
View reviewed changes
controller/metrics/metrics_test.go
metricsServ, err := NewMetricsServer("localhost:8082", appLister, appFilter, noOpHealthCheck, []string{}, []string{})
require.NoError(t, err)

expectedMetrics := `
Copy link
Member

@agaudreault agaudreault Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test should not be removed

@github-project-automation github-project-automation bot moved this from Ready for final review to Changes Requested in Argo CD Review Jun 13, 2025
@agaudreault
Copy link
Member

agaudreault commented Jun 13, 2025

Closing due to #23362

@github-project-automation github-project-automation bot moved this from Changes Requested to Done in Argo CD Review Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agaudreault agaudreault agaudreault requested changes

@nitishfy nitishfy Awaiting requested review from nitishfy

@todaywasawesome todaywasawesome Awaiting requested review from todaywasawesome

@sivchari sivchari Awaiting requested review from sivchari

+1 more reviewer

@andrii-korotkov andrii-korotkov andrii-korotkov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-for-review An approver should give a final review and merge the PR

Projects

Argo CD Review
Status: Done

Milestone

v3.1

Development

Successfully merging this pull request may close these issues.

Bump Kubernetes v1.33

7 participants

@chansuke @sivchari @crenshaw-dev @agaudreault @andrii-korotkov @todaywasawesome @nitishfy