Skip to content

Conversation

@lukepatrick
Copy link
Contributor

@lukepatrick lukepatrick commented Feb 17, 2025

PR implements healths check for core.spinkube.dev/SpinApp

core.spinkube.dev/SpinApp:

  • health.lua
  • tests

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell
Copy link

bunnyshell bot commented Feb 17, 2025

❗ Preview Environment undeploy from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to try again to remove the environment

@lukepatrick lukepatrick changed the title Implement spinkube SpinApp CRD health checks Feat: Implement spinkube SpinApp CRD health checks Feb 17, 2025
@lukepatrick lukepatrick changed the title Feat: Implement spinkube SpinApp CRD health checks feat: Implement spinkube SpinApp CRD health checks Feb 17, 2025
@lukepatrick lukepatrick force-pushed the feat/resource-customization-spinkube branch 2 times, most recently from 6d1a1ec to dfdda5f Compare March 23, 2025 19:02
@lukepatrick lukepatrick force-pushed the feat/resource-customization-spinkube branch from dfdda5f to 3fdd6dc Compare April 1, 2025 12:36
@lukepatrick lukepatrick marked this pull request as ready for review April 1, 2025 13:03
@lukepatrick lukepatrick requested a review from a team as a code owner April 1, 2025 13:03
@lukepatrick lukepatrick force-pushed the feat/resource-customization-spinkube branch from c43c32d to eead3da Compare April 2, 2025 09:19
@lukepatrick lukepatrick force-pushed the feat/resource-customization-spinkube branch from eead3da to bc5af21 Compare April 16, 2025 18:58
@lukepatrick lukepatrick force-pushed the feat/resource-customization-spinkube branch from bc5af21 to 5fa60bb Compare April 30, 2025 18:23
@crenshaw-dev crenshaw-dev added the component:health-check Issue related to built-in Health Check customizations label Apr 30, 2025
@lukepatrick lukepatrick force-pushed the feat/resource-customization-spinkube branch from 5fa60bb to 4eb5826 Compare May 24, 2025 22:38
@lukepatrick lukepatrick requested a review from crenshaw-dev May 24, 2025 23:18
@codecov
Copy link

codecov bot commented May 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.02%. Comparing base (b8051c6) to head (8b67790).
⚠️ Report is 417 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21896   +/-   ##
=======================================
  Coverage   60.01%   60.02%           
=======================================
  Files         343      343           
  Lines       57890    57890           
=======================================
+ Hits        34744    34746    +2     
+ Misses      20362    20359    -3     
- Partials     2784     2785    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukepatrick lukepatrick force-pushed the feat/resource-customization-spinkube branch 4 times, most recently from c095937 to e7d8a49 Compare May 28, 2025 21:35
@lukepatrick lukepatrick force-pushed the feat/resource-customization-spinkube branch from e7d8a49 to 8b67790 Compare May 29, 2025 16:02
@crenshaw-dev crenshaw-dev merged commit 7d66044 into argoproj:master May 29, 2025
28 checks passed
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:health-check Issue related to built-in Health Check customizations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants