-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: Implement spinkube SpinApp CRD health checks #21896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
crenshaw-dev
merged 3 commits into
argoproj:master
from
lukepatrick:feat/resource-customization-spinkube
May 29, 2025
Merged
feat: Implement spinkube SpinApp CRD health checks #21896
crenshaw-dev
merged 3 commits into
argoproj:master
from
lukepatrick:feat/resource-customization-spinkube
May 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Preview Environment undeploy from Bunnyshell failedSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
6d1a1ec to
dfdda5f
Compare
dfdda5f to
3fdd6dc
Compare
c43c32d to
eead3da
Compare
eead3da to
bc5af21
Compare
bc5af21 to
5fa60bb
Compare
crenshaw-dev
requested changes
Apr 30, 2025
5fa60bb to
4eb5826
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21896 +/- ##
=======================================
Coverage 60.01% 60.02%
=======================================
Files 343 343
Lines 57890 57890
=======================================
+ Hits 34744 34746 +2
+ Misses 20362 20359 -3
- Partials 2784 2785 +1 ☔ View full report in Codecov by Sentry. |
c095937 to
e7d8a49
Compare
Signed-off-by: lukepatrick <[email protected]>
Signed-off-by: lukepatrick <[email protected]>
Signed-off-by: lukepatrick <[email protected]>
e7d8a49 to
8b67790
Compare
crenshaw-dev
approved these changes
May 29, 2025
chansuke
pushed a commit
to chansuke/argo-cd
that referenced
this pull request
Jun 4, 2025
…21896) Signed-off-by: lukepatrick <[email protected]>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
…21896) Signed-off-by: lukepatrick <[email protected]> Signed-off-by: dsuhinin <[email protected]>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
…21896) Signed-off-by: lukepatrick <[email protected]> Signed-off-by: dsuhinin <[email protected]>
enneitex
pushed a commit
to enneitex/argo-cd
that referenced
this pull request
Aug 24, 2025
…21896) Signed-off-by: lukepatrick <[email protected]> Signed-off-by: enneitex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR implements healths check for core.spinkube.dev/SpinApp
core.spinkube.dev/SpinApp:
Checklist: