More comprehensive tests

Author: lukepatrick

resource_customizations/core.spinkube.dev/SpinApp/health.lua

@@ -1,21 +1,56 @@
 hs = {}
-if obj.status ~= nil then
-  if obj.status.conditions ~= nil then
-    for i, condition in ipairs(obj.status.conditions) do
-      if condition.type == "Progressing" and condition.status == "False" then
-        hs.status = "Degraded"
-        hs.message = condition.message
-        return hs
-      end
-      if condition.type == "Available" and condition.status == "True" then
-        hs.status = "Healthy"
-        hs.message = condition.message
-        return hs
-      end
+
+-- Check if status exists
+if not obj.status then
+  hs.status = "Degraded"
+  hs.message = "No status available"
+  return hs
+end
+
+-- Initialize variables for conditions
+local available = false
+local progressing = false
+local availableMessage = ""
+local progressingMessage = ""
+
+-- Check conditions
+if obj.status.conditions then
+  for _, condition in ipairs(obj.status.conditions) do
+    if condition.type == "Available" then
+      available = condition.status == "True"
+      availableMessage = condition.message or "Application availability status"
+    elseif condition.type == "Progressing" then
+      progressing = condition.status == "True"
+      progressingMessage = condition.message or "Application progress status"
     end
   end
 end
 
-hs.status = "Progressing"
-hs.message = "Waiting for SpinApp to be available"
+-- Check ready replicas if specified
+local readyReplicas = obj.status.readyReplicas or 0
+local desiredReplicas = obj.spec.replicas or 1
+
+-- Determine status based on conditions
+if not available then
+  hs.status = "Degraded"
+  hs.message = availableMessage or "Application is not available"
+  return hs
+end
+
+if readyReplicas < desiredReplicas then
+  hs.status = "Progressing"
+  hs.message = string.format("Waiting for replicas to be ready (%d/%d)", readyReplicas, desiredReplicas)
+  return hs
+end
+
+if progressing then
+  hs.status = "Progressing"
+  hs.message = progressingMessage or "Application is still progressing"
+  return hs
+end
+
+-- All checks passed
+hs.status = "Healthy"
+hs.message = string.format("Application is healthy with %d/%d replicas ready", readyReplicas, desiredReplicas)
+
 return hs

resource_customizations/core.spinkube.dev/SpinApp/health_test.yaml

@@ -0,0 +1,36 @@
+tests:
+  - name: "healthy-spinapp"
+    inputFile: "testdata/healthy.yaml"
+    expected:
+      status: "Healthy"
+      message: "Application is healthy with 2/2 replicas ready"
+
+  - name: "degraded-spinapp"
+    inputFile: "testdata/degraded.yaml"
+    expected:
+      status: "Degraded"
+      message: "ReplicaSet has timed out progressing."
+
+  - name: "progressing-spinapp"
+    inputFile: "testdata/progressing.yaml"
+    expected:
+      status: "Progressing"
+      message: "Application is still progressing"
+
+  - name: "no-status"
+    input:
+      spec:
+        replicas: 2
+    expected:
+      status: "Degraded"
+      message: "No status available"
+
+  - name: "no-conditions"
+    input:
+      status:
+        readyReplicas: 2
+      spec:
+        replicas: 2
+    expected:
+      status: "Degraded"
+      message: "Application is not available"