-
Notifications
You must be signed in to change notification settings - Fork 49
chore: Update README for install instructions #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: jbrard <[email protected]>
|
Looks nice!! Thanks |
README.md
Outdated
| in Argo CD API server. This process can be automated by using the | ||
| [argocd-extension-installer][1]. This installation method will run an | ||
| init container that will download, extract and place the file in the | ||
| correct location. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach uses the argocd-extension-installer init container which runs during the startup of the argocd server.
The init container downloads and extracts the JS file to /tmp/extensions. The argocd interface mounts the external JS file within the rollout resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, please take a look and re-review at your leisure.
Signed-off-by: jbrard <[email protected]>
|
Make sense to include also instructions about how to install it using other alternatives as ArgoCD Helm chart? |
Signed-off-by: jbrard <[email protected]>
@jsolana Updated to have helm options as well. |
|
This is a nice improvement and I used it today. Any chance it can get merged soon? |
Happy to hear you found some use. Sadly I don't have write access to this respository |
|
@rbreeze able to review? I see you have had recent contributions to this repo |
|
This is AMAZING! Thanks for the EZ button. :) |
|
Wish this was merged before I looked all over the repos for how to |
|
@ashutosh16 @alexmt @rbreeze @alexef Can we get this merged in? |
Closes #68, Closes #24, Closes #62
Open to making this more verbose, let me know.