Skip to content

Conversation

@standardloop
Copy link
Contributor

@standardloop standardloop commented Jan 27, 2024

Closes #68, Closes #24, Closes #62

Open to making this more verbose, let me know.

Signed-off-by: jbrard <[email protected]>
@jsolana
Copy link

jsolana commented Jan 29, 2024

Looks nice!! Thanks

README.md Outdated
in Argo CD API server. This process can be automated by using the
[argocd-extension-installer][1]. This installation method will run an
init container that will download, extract and place the file in the
correct location.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach uses the argocd-extension-installer init container which runs during the startup of the argocd server.
The init container downloads and extracts the JS file to /tmp/extensions. The argocd interface mounts the external JS file within the rollout resource.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, please take a look and re-review at your leisure.

@jsolana
Copy link

jsolana commented Jan 31, 2024

Make sense to include also instructions about how to install it using other alternatives as ArgoCD Helm chart?

@standardloop
Copy link
Contributor Author

Make sense to include also instructions about how to install it using other alternatives as ArgoCD Helm chart?

@jsolana Updated to have helm options as well.

@reilly3000
Copy link

This is a nice improvement and I used it today. Any chance it can get merged soon?

@standardloop
Copy link
Contributor Author

This is a nice improvement and I used it today. Any chance it can get merged soon?

Happy to hear you found some use.

Sadly I don't have write access to this respository

@standardloop
Copy link
Contributor Author

@rbreeze able to review? I see you have had recent contributions to this repo

@taer
Copy link

taer commented Apr 24, 2024

This is AMAZING! Thanks for the EZ button. :)

@rgarrigue
Copy link

Wish this was merged before I looked all over the repos for how to

@standardloop
Copy link
Contributor Author

@ashutosh16 @alexmt @rbreeze @alexef

Can we get this merged in?

@rbreeze rbreeze merged commit ac667b6 into argoproj-labs:master May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

7 participants