fix: missing namespace on clusterrolebinding in install manifests #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheng Fang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #860 +/- ##
==========================================
+ Coverage 73.50% 74.39% +0.89%
==========================================
Files 31 31
Lines 3144 3144
==========================================
+ Hits 2311 2339 +28
+ Misses 695 669 -26
+ Partials 138 136 -2 ☔ View full report in Codecov by Sentry. |
jannfis
reviewed
Sep 10, 2024
Co-authored-by: Jann Fischer <[email protected]> Signed-off-by: Cheng Fang <[email protected]>
Tchoupinax
pushed a commit
to Tchoupinax/argocd-image-updater
that referenced
this pull request
Oct 23, 2024
…goproj-labs#860) Signed-off-by: Cheng Fang <[email protected]> Co-authored-by: Jann Fischer <[email protected]> Signed-off-by: Tchoupinax <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #859
PR #848 added a clusterrolebinding without specifying SA namespace to the install manifests, causing the installation to fail. This PR fixes the problem by adding a default SA namespace
argocdto the clusterrolebinding, and also updates the docs with a reminder/warning for the need to change the namespace if necessary. Tested with installing both plain manifest and kustomization.