feat: Sync namespace for Event to the Application namespace (#847)

[jortkoopmans]

Sync namespace for Event to the Application namespace (#847)

Note that this does assume that the kubernetes client has permissions to create Events on the particular namespace (this typically depends on cluster RBAC)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.43%. Comparing base (40f260a) to head (d0c3300).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #848   +/-   ##
=======================================
  Coverage   73.43%   73.43%           
=======================================
  Files          31       31           
  Lines        3136     3136           
=======================================
  Hits         2303     2303           
  Misses        695      695           
  Partials      138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jannfis]

Will we need RBAC changes for that to allow the image updater the creation of events in those namespaces?

[jortkoopmans]

Will we need RBAC changes for that to allow the image updater the creation of events in those namespaces?

Thank you for the quick feedback.
Yes, some additional permissions are required, I've added a commit proposing to move the Event create permission to a ClusterRole.
Theoretically a cluster operator might prefer creating separate roles for specific namespaces where Applications will be residing, but managing those roles can become tedious.

[jannfis]

LGTM! Thanks for your contribution!

[chengfang]

@jortkoopmans can you please take a look at the regression reported in issue #859? Thanks.