Skip to content

fix: Do not retrieve metadata for all tags with digest strategy #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2022
Merged

fix: Do not retrieve metadata for all tags with digest strategy #337

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6a1e85
fix: Only fetch metadata for constraint tag in digest strategx
jannfis Jan 9, 2022
66fba63
fix: Only fetch metadata for constraint tag in digest strategx
jannfis Jan 9, 2022
9322281
fix: Only fetch metadata for constraint tag in digest strategx
jannfis Jan 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pkg/registry/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,16 @@ func (endpoint *RegistryEndpoint) GetTags(img *image.ContainerImage, regClient R

tags := []string{}

// Loop through tags, removing those we do not want
if vc.MatchFunc != nil || len(vc.IgnoreList) > 0 {
// For digest strategy, we do require a version constraint
if vc.SortMode == image.VersionSortDigest && vc.Constraint == "" {
return nil, fmt.Errorf("cannot use digest strategy for image %s without a version constraint", img.Original())
}

// Loop through tags, removing those we do not want. If update strategy is
// digest, all but the constraint tag are ignored.
if vc.MatchFunc != nil || len(vc.IgnoreList) > 0 || vc.SortMode == image.VersionSortDigest {
for _, t := range tTags {
if (vc.MatchFunc != nil && !vc.MatchFunc(t, vc.MatchArgs)) || vc.IsTagIgnored(t) {
if (vc.MatchFunc != nil && !vc.MatchFunc(t, vc.MatchArgs)) || vc.IsTagIgnored(t) || (vc.SortMode == image.VersionSortDigest && t != vc.Constraint) {
log.Tracef("Removing tag %s because it either didn't match defined pattern or is ignored", t)
} else {
tags = append(tags, t)
Expand Down