fix: Do not retrieve metadata for all tags with digest strategy #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jannfis <[email protected]>
Signed-off-by: jannfis <[email protected]>
Signed-off-by: jannfis <[email protected]>
jannfis
added a commit
that referenced
this pull request
Jan 10, 2022
* fix: Only fetch metadata for constraint tag in digest strategx Signed-off-by: jannfis <[email protected]> * fix: Only fetch metadata for constraint tag in digest strategx Signed-off-by: jannfis <[email protected]> * fix: Only fetch metadata for constraint tag in digest strategx Signed-off-by: jannfis <[email protected]>
|
@jannfis Thank you for fixing this - it decreased our API calls by many of orders of magnitude, and dramatically increases the responsiveness of the image updater for our developers! |
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
…proj-labs#337) * fix: Only fetch metadata for constraint tag in digest strategx Signed-off-by: jannfis <[email protected]> * fix: Only fetch metadata for constraint tag in digest strategx Signed-off-by: jannfis <[email protected]> * fix: Only fetch metadata for constraint tag in digest strategx Signed-off-by: jannfis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using digest update strategy, the Image Updater would have fetched metadata for all tags returned by the registry. For digest strategy, caching is also disabled and this leads to too many requests to the registry.
Now, only metadata for the tag specified in the version constraint is fetched. All other tags are skipped.
Fixes #313