chore(deps): bump registry-scanner version to the latest in master, and activate the its replace clause for development #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengfang
requested review from
ishitasequeira,
jannfis and
pasha-codefresh
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1234 +/- ##
=======================================
Coverage 63.77% 63.77%
=======================================
Files 23 23
Lines 3213 3213
=======================================
Hits 2049 2049
Misses 1054 1054
Partials 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nd activate the its replace clause for development Signed-off-by: Cheng Fang <[email protected]>
chengfang
force-pushed
the
registry-scanner.dep
branch
from
233502b to
f7cdcad
Compare
dkarpele
approved these changes
Sep 10, 2025
dkarpele
pushed a commit
to dkarpele/argocd-image-updater
that referenced
this pull request
Sep 16, 2025
…nd activate the its replace clause for development (argoproj-labs#1234) Signed-off-by: Cheng Fang <[email protected]> (cherry picked from commit 9daecb3) Signed-off-by: Denis Karpelevich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current go.mod references a fixed version of registry-scanner library. Often we need to modify registry-scanner library API and use that in image-updater in the same commit or pull request. In local environment, we can manually uncomment the replace line, but CI checks will fail. The usual fix to this problem is to split the changes into 2 pull requests: the 1st for the changes in registry-scanner, and 2nd for the changes in image-updater referencing the newly updated registry-scanner API. Some pull requests (e.g., #1231) were experiencing this issue.
This PR enables immediate use of any changes in registry-scanner across image-updater codebase.