-
Notifications
You must be signed in to change notification settings - Fork 313
Add support for JSON log formatting #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4324b57 to
776e722
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1231 +/- ##
==========================================
- Coverage 63.77% 63.58% -0.19%
==========================================
Files 23 23
Lines 3213 3224 +11
==========================================
+ Hits 2049 2050 +1
- Misses 1054 1064 +10
Partials 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
776e722 to
41f0b88
Compare
jannfis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you.
LGTM.
jannfis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was too quick with my approval 😅
Please check my comments.
|
According to https://argo-cd.readthedocs.io/en/stable/user-guide/commands/argocd_admin/#options, argocd uses |
41f0b88 to
c03a733
Compare
|
@mikepilat I moved the changes related to registry-scanner replacement into a seprate #1234 since that could also benefit other PRs in the same concurrent update situation. I also took the liberty to resolve the conflicts and pushed to your branch. Can you please review the remaining comments in this PR so we can include this in the upcoming release? |
|
@chengfang Thanks for bringing that upstream! Other PR feedback has been incorporated. |
- Add log setter for text or JSON log formatting - Add CLI option "--log-format", accepts "text" or "json" - Defaults to current "text" logging for compatibility Signed-off-by: Michael Pilat <[email protected]>
Signed-off-by: Michael Pilat <[email protected]>
7f3a65b to
2b56830
Compare
Signed-off-by: Michael Pilat <[email protected]> (cherry picked from commit 62a5452) Signed-off-by: Denis Karpelevich <[email protected]>
Fixes #436
Fixes #515
Additionally:
cmdgo.mod to reference registry-scanner locally to support concurrent changes in both modules