Skip to content

add error reporting to block #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2024
Merged

add error reporting to block #2580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f360de
add error reporting to block
AidasK May 4, 2024
d814f99
Update new configuration description
ifox May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions config/twill.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,14 @@
*/
'debug' => env('APP_DEBUG', false),

/*
|--------------------------------------------------------------------------
| This parameter will throw errors if some error occurs instead of failing
| silently (eg. when rendering blocks)
|--------------------------------------------------------------------------
*/
'strict' => env('TWILL_STRICT', false),

/*
|--------------------------------------------------------------------------
| Base classes for automatic generation of Modules and Capsules
Expand Down
4 changes: 4 additions & 0 deletions src/Services/Blocks/Block.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,11 +686,15 @@ public function renderView(
try {
return view($view, $data)->render();
} catch (Exception $e) {
if (config('twill.strict')) {
throw $e;
}
if (config('twill.debug')) {
$error = $e->getMessage() . ' in ' . $e->getFile();

return View::make('twill::errors.block', ['view' => $view, 'error' => $error])->render();
}
report($e);
}

return '';
Expand Down