add error reporting to block #2580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AidasK
force-pushed
the
feat/AidasK-patch-2
branch
from
c1f2b05 to
2f360de
Compare
ifox
requested changes
May 24, 2024
ifox
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors are not reported and displayed on production. This mr is based on #2540 issue and based on a discussion on discord https://discord.com/channels/811936425858695198/811986440569356308/1219656775125700748
Heads up, after this MR is merged, existing users should expect errors flowing due to added
report($e);. IMO it's a good thing since errors will get fixed.