Skip to content

build: harmonize docker image pushes #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jandom merged 1 commit into from
Feb 13, 2026
Merged

build: harmonize docker image pushes #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
GH_PAT: ${{ secrets.GH_PAT }}

push-to-registry:
name: Push Docker image to Docker Hub
name: Push Docker image to registries
runs-on: ${{ fromJSON(needs.start-aws-runner.outputs.instances) }}
needs:
- start-aws-runner
Expand All @@ -54,7 +54,18 @@ jobs:
- name: Check out the repo
uses: actions/checkout@v6

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Log in to GitHub Container Registry
uses: docker/login-action@28fdb31ff34708d19615a74d67103ddc2ea9725c
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Log in to Docker Hub
if: github.repository == 'aqlaboratory/openfold-3'
uses: docker/login-action@28fdb31ff34708d19615a74d67103ddc2ea9725c
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
Expand All @@ -64,7 +75,9 @@ jobs:
id: meta
uses: docker/metadata-action@a60f0f62b5c12316066c8db464bfb2faafd7907b
with:
images: openfoldconsortium/openfold3
images: |
name=ghcr.io/${{ github.repository }}/openfold3-docker
name=openfoldconsortium/openfold3,enable=${{ github.repository == 'aqlaboratory/openfold-3' }}
Comment on lines -67 to +80
Copy link
Collaborator Author

@jandom jandom Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was curious to me

Copy link
Contributor

@jnwei jnwei Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which part is curious? If this is about the missing - in the name of the docker image, it's because dockerhub doesn't allow docker names with hyphens.

Copy link
Collaborator Author

@jandom jandom Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, just the multiple name tags and how they can be mixed with the enable tag. Never seen something like this before.

tags: |
type=raw,value=${{ inputs.version }},enable=${{ github.event_name == 'workflow_dispatch' }}
type=raw,value=${{ inputs.additional_tags }},enable=${{ inputs.additional_tags != '' && github.event_name == 'workflow_dispatch' }}
Expand All @@ -75,12 +88,14 @@ jobs:
uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83
with:
context: .
file: ./Dockerfile
Copy link
Collaborator Author

@jandom jandom Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file no longer exists

file: docker/Dockerfile
target: devel
push: true
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}

- name: Generate artifact attestation
if: github.repository == 'aqlaboratory/openfold-3'
uses: actions/attest-build-provenance@v3
with:
subject-name: index.docker.io/openfoldconsortium/openfold3
Expand Down