Skip to content

build: harmonize docker image pushes#126

Merged
jandom merged 1 commit intomainfrom
jandom/2026-02/build/harmonize-docker-image-push
Feb 13, 2026
Merged

build: harmonize docker image pushes#126
jandom merged 1 commit intomainfrom
jandom/2026-02/build/harmonize-docker-image-push

Conversation

@jandom
Copy link
Collaborator

@jandom jandom commented Feb 12, 2026

Summary

Pushes to GHCR (all) and DockerHub (only public)

Changes

Related Issues

Testing

Other Notes

@jandom jandom requested a review from jnwei February 12, 2026 13:39
@jandom jandom self-assigned this Feb 12, 2026
Comment on lines -67 to +80
images: openfoldconsortium/openfold3
images: |
name=ghcr.io/${{ github.repository }}/openfold3-docker
name=openfoldconsortium/openfold3,enable=${{ github.repository == 'aqlaboratory/openfold-3' }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was curious to me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which part is curious? If this is about the missing - in the name of the docker image, it's because dockerhub doesn't allow docker names with hyphens.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, just the multiple name tags and how they can be mixed with the enable tag. Never seen something like this before.

uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83
with:
context: .
file: ./Dockerfile
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file no longer exists

Copy link
Contributor

@jnwei jnwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for updating the docker publishing workflow

@jandom jandom merged commit 6c32c92 into main Feb 13, 2026
2 checks passed
@jandom jandom deleted the jandom/2026-02/build/harmonize-docker-image-push branch February 13, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants