refactor: enhance deploy_preview.sh script for improved AWS configura…#41042
Merged
pratapaprasanna merged 1 commit intoreleasefrom Jun 25, 2025
Merged
refactor: enhance deploy_preview.sh script for improved AWS configura…#41042pratapaprasanna merged 1 commit intoreleasefrom
pratapaprasanna merged 1 commit intoreleasefrom
Conversation
…tion ### Changes Made - Updated the script to set strict error handling with `set -euo pipefail`. - Streamlined AWS CLI configuration by creating the `~/.aws/config` file directly. - Removed deprecated `dp-node-affinity-values.yaml` file and integrated node affinity and tolerations directly into the Helm chart deployment command. - Improved pod name retrieval and added optional cleanup logic for better resource management during deployment. These changes enhance the reliability and maintainability of the deployment process.
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThe deployment script was updated for stricter error handling, clearer environment setup, and improved cleanup logic. Node scheduling constraints for Helm deployments are now set inline, and memory requests were increased. The separate YAML file for node affinity was removed, with its configuration moved directly into the deployment command. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DeployScript
participant AWS
participant Kubernetes
participant Helm
User->>DeployScript: Run deploy_preview.sh
DeployScript->>AWS: Configure CLI with region/output
DeployScript->>Kubernetes: Update kubeconfig, set context
DeployScript->>Kubernetes: Cleanup resources (conditional)
DeployScript->>Kubernetes: Create namespace/secret (ignore exists)
DeployScript->>Helm: Add repo, install plugin (ignore exists)
DeployScript->>Helm: Deploy with inline node affinity/tolerations, increased memory
Helm->>Kubernetes: Apply deployment
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion
Changes Made
set -euo pipefail.~/.aws/configfile directly.dp-node-affinity-values.yamlfile and integrated node affinity and tolerations directly into the Helm chart deployment command.These changes enhance the reliability and maintainability of the deployment process.
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit