fix: update cluster name in deploy_preview script and adjust kubeconf…#40981
Merged
pratapaprasanna merged 1 commit intoreleasefrom Jun 25, 2025
Merged
fix: update cluster name in deploy_preview script and adjust kubeconf…#40981pratapaprasanna merged 1 commit intoreleasefrom
pratapaprasanna merged 1 commit intoreleasefrom
Conversation
…ig command ### 📝 Summary This commit updates the cluster name in the `deploy_preview.sh` script from `uat-cluster` to `uatx-cluster` and modifies the `aws eks update-kubeconfig` command to remove the profile option, ensuring compatibility with the current AWS configuration. ### 🎨 Changes Made - **Cluster Name Update**: Changed `export cluster_name=uat-cluster` to `export cluster_name=uatx-cluster`. - **Kubeconfig Command Adjustment**: Removed the `--profile eksci` option from the `aws eks update-kubeconfig` command for streamlined execution. No user-facing changes were made, and the script remains functional for deployment tasks.
Contributor
WalkthroughThe deployment script was updated to use a new AWS EKS cluster name and now configures kubeconfig without specifying an AWS profile, relying on default credentials or environment variables. No other logic or functional aspects of the script were changed. Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
scripts/deploy_preview.sh (1)
51-53: Review kubeconfig command changes
- Removing
--profile eksciis valid if AWS creds are managed via environment or default profile.- Consider deleting the commented-out legacy command to keep the script tidy.
Please test this in both CI and your local environment to confirm the correct credentials are picked up.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
scripts/deploy_preview.sh(2 hunks)
🔇 Additional comments (1)
scripts/deploy_preview.sh (1)
14-14: Cluster name updated – verify resource existence
Ensure that the new clusteruatx-clusteris provisioned and accessible in your AWS account to prevent silent failures during the preview deployment.
This was referenced Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ig command
📝 Summary
This commit updates the cluster name in the
deploy_preview.shscript fromuat-clustertouatx-clusterand modifies theaws eks update-kubeconfigcommand to remove the profile option, ensuring compatibility with the current AWS configuration.🎨 Changes Made
export cluster_name=uat-clustertoexport cluster_name=uatx-cluster.--profile ekscioption from theaws eks update-kubeconfigcommand for streamlined execution.No user-facing changes were made, and the script remains functional for deployment tasks.
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit