Skip to content

PendingDatagramWritesManager split close and failAll steps #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rnro wants to merge 1 commit into from
Closed

PendingDatagramWritesManager split close and failAll steps #3221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions Sources/NIOPosix/PendingDatagramWritesManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,13 +693,16 @@ final class PendingDatagramWritesManager: PendingWritesManager {
}
}

/// Fail all the outstanding writes. This is useful if for example the `Channel` is closed.
func failAll(error: Error, close: Bool) {
if close {
assert(self.isOpen)
self.isOpen = false
}
/// Close the write manager and fail all the outstanding writes. This is useful if for example the `Channel` is closed.
func closeAndFailAll(error: Error) {
assert(self.isOpen)
self.isOpen = false

self.failAll(error: error)
}

/// Fail all the outstanding writes. This is useful if for example the `Channel` is closed.
Copy link
Contributor

@Lukasa Lukasa Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful to clean up these doc comments and explain where we might do one and the other.

func failAll(error: Error) {
self.state.failAll(error: error)

assert(self.state.isEmpty)
Expand Down
Loading