PendingDatagramWritesManager split close and failAll steps #3221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: PendingDatagramWritesManager split close and failAll steps of the failAll method into two explicit methods. This separates concerns and makes future changes more straightforwards. Modifications: PendingDatagramWritesManager split close and failAll steps of the failAll method into two explicit methods. Result: No behavioral change
Lukasa
reviewed
Apr 23, 2025
| self.failAll(error: error) | ||
| } | ||
|
|
||
| /// Fail all the outstanding writes. This is useful if for example the `Channel` is closed. |
Contributor
There was a problem hiding this comment.
It might be useful to clean up these doc comments and explain where we might do one and the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
PendingDatagramWritesManager split close and failAll steps of the failAll method into two explicit methods. This separates concerns and makes future changes more straightforwards.
Modifications:
PendingDatagramWritesManager split close and failAll steps of the failAll method into two explicit methods.
Result:
No behavioral change