Skip to content

Remove noasync from NIOFileHandle #3001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukasa merged 4 commits into from
Nov 27, 2024
Merged

Remove noasync from NIOFileHandle #3001

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57e4ad8
Remove noasync from NIOFileHandle
glbrntt Nov 26, 2024
e2f2fb2
Merge branch 'main' into nonoasync
Lukasa Nov 26, 2024
704ef82
nononoasync on new inits
glbrntt Nov 27, 2024
16b254d
Merge branch 'main' into nonoasync
glbrntt Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Sources/NIOCore/FileHandle.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,6 @@ extension NIOFileHandle {
use NIOFileSystem as a replacement API.
"""
)
@available(*, noasync, message: "This method may block the calling thread")
public convenience init(
path: String,
mode: Mode = .read,
Expand All @@ -388,7 +387,6 @@ extension NIOFileHandle {
/// - path: The path of the file to open. The ownership of the file descriptor is transferred to this `NIOFileHandle` and so it will be closed once `close` is called.
/// - mode: Access mode. Default mode is `.read`.
/// - flags: Additional POSIX flags.
@available(*, noasync, message: "This method may block the calling thread")
Copy link
Member

@weissi weissi Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glbrntt We can keep it on the new methods though, no?

Copy link
Contributor Author

@glbrntt glbrntt Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're absolutely right.

public convenience init(
_deprecatedPath path: String,
mode: Mode = .read,
Expand All @@ -415,7 +413,6 @@ extension NIOFileHandle {
use NIOFileSystem as a replacement API.
"""
)
@available(*, noasync, message: "This method may block the calling thread")
public convenience init(path: String) throws {
try self.init(_deprecatedPath: path)
}
Expand All @@ -424,7 +421,6 @@ extension NIOFileHandle {
///
/// - Parameters:
/// - path: The path of the file to open. The ownership of the file descriptor is transferred to this `NIOFileHandle` and so it will be closed once `close` is called.
@available(*, noasync, message: "This method may block the calling thread")
public convenience init(_deprecatedPath path: String) throws {
// This function is here because we had a function like this in NIO 2.0, and the one above doesn't quite match. Sadly we can't
// really deprecate this either, because it'll be preferred to the one above in many cases.
Expand Down