Remove noasync from NIOFileHandle #3001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In apple#2598, `NIOFileHandle` was annotated with `noasync` in a few places. This is, unfortunately, a breaking change. Modifications: - Remove the `noasync` annotations Result: Adopters aren't broken
Lukasa
approved these changes
Nov 26, 2024
Lukasa
approved these changes
Nov 26, 2024
weissi
reviewed
Nov 26, 2024
| /// - path: The path of the file to open. The ownership of the file descriptor is transferred to this `NIOFileHandle` and so it will be closed once `close` is called. | ||
| /// - mode: Access mode. Default mode is `.read`. | ||
| /// - flags: Additional POSIX flags. | ||
| @available(*, noasync, message: "This method may block the calling thread") |
Member
There was a problem hiding this comment.
@glbrntt We can keep it on the new methods though, no?
Contributor
Author
There was a problem hiding this comment.
Yeah, you're absolutely right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In #2598,
NIOFileHandlewas annotated withnoasyncin a few places. This is, unfortunately, a breaking change.Modifications:
noasyncannotationsResult:
Adopters aren't broken