Handle Sendability of RemovableChannelHandler #2953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: RemovableChannelHandlers have a large API surface in NIOCore. That API surface is a bit awkward with regard to strict concurrency, and needs some cleanup. Modifications: This patch adds some new API that is necessary to safely work with RemovableChannelHandlers, deprecates some API that cannot plausibly be used, and cleans up some other parts of the API. Result: Easier to work with RemovableChannelHandlers
Lukasa
force-pushed
the
cb-strict-concurrency-removable-handler
branch
from
40cdd33 to
803eac6
Compare
FranzBusch
approved these changes
Oct 28, 2024
FranzBusch
approved these changes
Oct 29, 2024
Contributor
Author
|
Merging over the API breakage, which is expected and safe. |
Lukasa
added a commit
to Lukasa/swift-nio
that referenced
this pull request
Nov 20, 2024
This reverts commit 411c2c5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
RemovableChannelHandlers have a large API surface in NIOCore. That API surface is a bit awkward with regard to strict concurrency, and needs some cleanup.
Modifications:
This patch adds some new API that is necessary to safely work with RemovableChannelHandlers, deprecates some API that cannot plausibly be used, and cleans up some other parts of the API.
Result:
Easier to work with RemovableChannelHandlers