doc: Add rust apollo client link#5514
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
WalkthroughThis PR adds documentation for Apollo Rust client 3 across multiple language editions. A changelog entry is added to CHANGES.md for Apollo 2.5.0, and new sections are appended to both English and Chinese SDK user guides referencing the project and providing attribution. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
CHANGES.md(1 hunks)docs/en/client/rust-sdks-user-guide.md(1 hunks)docs/zh/client/rust-sdks-user-guide.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build (8)
🔇 Additional comments (2)
docs/zh/client/rust-sdks-user-guide.md (1)
12-19: Proper documentation addition following established patterns.The new section follows the same structure and formatting as the existing Apollo Rust client sections above it, with correct attribution and project link.
CHANGES.md (1)
27-27: Changelog entry properly formatted and placed.The entry follows the established format with correct markdown syntax and PR reference.
|
|
||
| ### Apollo Rust client 3 | ||
|
|
||
| Project address: [apollo-client](https://github.com/jmjoy/apollo-client) | ||
|
|
||
| > Thanks [@jmjoy](https://github.com/jmjoy) for providing support for the Rust Apollo client |
There was a problem hiding this comment.
Minor punctuation inconsistency in the English documentation.
The new section uses a regular colon (Project address:) on line 17, but the existing sections above it use full-width colons (Project address:) on lines 3 and 11. For consistency within this document, please align the punctuation style.
Apply this diff to standardize the punctuation:
-Project address: [apollo-client](https://github.com/jmjoy/apollo-client)
+Project address: [apollo-client](https://github.com/jmjoy/apollo-client)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ### Apollo Rust client 3 | |
| Project address: [apollo-client](https://github.com/jmjoy/apollo-client) | |
| > Thanks [@jmjoy](https://github.com/jmjoy) for providing support for the Rust Apollo client | |
| ### Apollo Rust client 3 | |
| Project address: [apollo-client](https://github.com/jmjoy/apollo-client) | |
| > Thanks [@jmjoy](https://github.com/jmjoy) for providing support for the Rust Apollo client |
🤖 Prompt for AI Agents
In docs/en/client/rust-sdks-user-guide.md around lines 14 to 19, the "Project
address:" label uses a regular colon while other entries use a full-width colon;
change the regular colon to a full-width colon (:) so the punctuation matches
the other sections and maintain document consistency.
What's the purpose of this PR
This pull request updates the Rust client documentation to include a new Apollo Rust client implementation. Both the English and Chinese user guides now reference the
apollo-clientproject byjmjoy.Which issue(s) this PR fixes:
Fixes #
Brief changelog
doc: Add rust apollo client link
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.mvn spotless:applyto format your code.CHANGESlog.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.