Added links to apollo-rust-client, a new Rust based client that supports both Rust and NodeJS via WASM#5415
Added links to apollo-rust-client, a new Rust based client that supports both Rust and NodeJS via WASM#5415nobodyiam merged 6 commits intoapolloconfig:masterfrom qqiao:add-apollo-rust-client-links
Conversation
dosubot
bot
added
the
size:S
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Warning Rate limit exceeded@qqiao has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 45 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
WalkthroughA new documentation section titled "Apollo Rust Client" was added to both English and Chinese user guides for Node.js and Rust SDKs. This section introduces a Rust and WASM-compatible Apollo client, includes a repository link, and credits the contributor. No existing content or code functionality was changed. Changes
Suggested labels
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
docs/en/client/nodejs-sdks-user-guide.md (1)
42-49: Section label & gratitude text are misleading – update to reflect a Rust client, fix “NodeJS” spelling
- The Node.js SDKs guide suddenly lists a Rust client. Because this client only runs in Node.js via WASM, add a short parenthetical note to avoid confusing readers who expect a pure-JS client.
- “NodeJS” → “Node.js” (official spelling) in line 49.
- Gratitude line should say “Rust Apollo client”, not “NodeJS Apollo client”.
-### Apollo Rust Client +Apollo Rust Client (runs in Node.js via WASM) ... -> Thanks to [@qqiao](https://github.com/qqiao) for providing support for the NodeJS Apollo client +> Thanks to [@qqiao](https://github.com/qqiao) for providing support for the Rust Apollo clientdocs/zh/client/rust-sdks-user-guide.md (1)
6-11: 统一大小写与专有名词格式
- “apollo 客户端” → “Apollo 客户端” 以保持专有名词大小写一致。
- 如果希望与上方标题区分，可在第 8 行句末加句号。
-一个同时支持 Rust 以及 WASM 的 apollo 客户端 +一个同时支持 Rust 以及 WASM 的 Apollo 客户端。docs/zh/client/nodejs-sdks-user-guide.md (1)
43-48: 缺少标点并且大小写不一致
- 在第 45 行中文句末缺少句号。
- “apollo 客户端” → “Apollo 客户端”。
- 行 48 的感谢语说“NodeJS Apollo客户端”，但此处介绍 Rust 客户端，建议改为 “Rust Apollo 客户端”。
- “NodeJS” → “Node.js”。
-一个同时支持 Rust 以及 WASM 的 apollo 客户端 +一个同时支持 Rust 以及 WASM 的 Apollo 客户端。 -> 非常感谢[@qqiao](https://github.com/qqiao)提供NodeJS Apollo客户端的支持 +> 非常感谢[@qqiao](https://github.com/qqiao)提供 Rust Apollo 客户端的支持docs/en/client/rust-sdks-user-guide.md (1)
7-13: Minor wording consistencyConsider lower-casing “WASM” to match most Rust/Wasm docs (“Wasm”) and drop the leading article for brevity.
-A client for Apollo that supports both Rust and WASM. +A client for Apollo that supports both Rust and Wasm.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
docs/en/client/nodejs-sdks-user-guide.md(1 hunks)docs/en/client/rust-sdks-user-guide.md(1 hunks)docs/zh/client/nodejs-sdks-user-guide.md(1 hunks)docs/zh/client/rust-sdks-user-guide.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/en/client/nodejs-sdks-user-guide.md
[uncategorized] ~49-~49: The official spelling of this programming framework is “Node.js”.
Context: ...om/qqiao) for providing support for the NodeJS Apollo client
(NODE_JS)
docs/zh/client/nodejs-sdks-user-guide.md
[uncategorized] ~45-~45: A punctuation mark might be missing here.
Context: ...Client 一个同时支持 Rust 以及 WASM 的 apollo 客户端 项目地址：[apollo-rust-client](https://github...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build (8)
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Co-authored-by: Jason Song <nobodyiam@gmail.com>
Co-authored-by: Jason Song <nobodyiam@gmail.com>
|
Updated as suggested |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/en/client/nodejs-sdks-user-guide.md (1)
43-44: Prefer official spelling “Node.js” for consistencyThe project’s docs generally use “Node.js”. Updating the new heading and gratitude line keeps terminology uniform.
-### Apollo NodeJS(WebAssembly) client 8 +### Apollo Node.js (WebAssembly) client 8 -> Thanks to [@qqiao](https://github.com/qqiao) for providing support for the NodeJS Apollo client +> Thanks to [@qqiao](https://github.com/qqiao) for providing support for the Node.js Apollo clientAlso applies to: 49-49
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/en/client/nodejs-sdks-user-guide.md(1 hunks)docs/en/client/rust-sdks-user-guide.md(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/en/client/rust-sdks-user-guide.md
🧰 Additional context used
🪛 LanguageTool
docs/en/client/nodejs-sdks-user-guide.md
[uncategorized] ~43-~43: The official spelling of this programming framework is “Node.js”.
Context: ...or the NodeJS Apollo client ### Apollo NodeJS(WebAssembly) client 8 A client for Apo...
(NODE_JS)
[uncategorized] ~49-~49: The official spelling of this programming framework is “Node.js”.
Context: ...om/qqiao) for providing support for the NodeJS Apollo client
(NODE_JS)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build (8)
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2 participants
What's the purpose of this PR
This PR is to add links in the documentation for https://github.com/qqiao/apollo-rust-client. A new Rust based client that supports both native Rust and NodeJS via cross compilation to WASM.
Brief changelog
Add link to https://github.com/qqiao/apollo-rust-client.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.Summary by CodeRabbit