Merged
Conversation
added 5 commits
June 15, 2015 15:31
Fixture IdP now tracks session until logged out
Collaborator
|
👍 LGTM |
ruby-saml does not include the ACS logout URL in the logout request, so this does not work This reverts commit 47e3fb2.
Collaborator
Author
|
I removed support for the |
added 2 commits
June 16, 2015 13:38
…redirect Attempting to avoid Capybara::Webkit::NodeNotAttachedError race condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SLO support to the plugin.
Configuring an
idp_slo_target_urlgets you basic SLO, with no verification of the logout response from the IdP.I removed support for the
assertion_consumer_logout_service_urlbecause ruby-saml does not support it in the logout request.I had to pull in lawrencepit/ruby-saml-idp#10 into the fixture IdP so that it would support SLO too. I also added a persistent session to the IdP to ensure that logout was meaningful.
Removed section: