Skip to content

feat: add impit option for Crawlee CLI #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

feat: add impit option for Crawlee CLI #1312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/crawlee/project_template/cookiecutter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"__package_name": "{{ cookiecutter.project_name|lower|replace('-', '_') }}",
"crawler_type": ["beautifulsoup", "parsel", "playwright", "playwright-camoufox"],
"__crawler_type": "{{ cookiecutter.crawler_type|lower|replace('-', '_') }}",
"http_client": ["httpx", "curl-impersonate"],
"http_client": ["httpx", "curl-impersonate", "impit"],
Copy link
Collaborator

@janbuchar janbuchar Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't impit be the default?

Copy link
Collaborator Author

@Mantisus Mantisus Jul 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be in the next PR, after the next impit release - #1307 😄

"package_manager": ["poetry", "pip", "uv"],
"enable_apify_integration": false,
"install_project": true,
Expand Down
4 changes: 4 additions & 0 deletions src/crawlee/project_template/templates/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
from crawlee.http_clients import CurlImpersonateHttpClient
# % elif cookiecutter.http_client == 'httpx'
from crawlee.http_clients import HttpxHttpClient
# % elif cookiecutter.http_client == 'impit'
from crawlee.http_clients import ImpitHttpClient
# % endif

from .routes import router
Expand All @@ -17,6 +19,8 @@
http_client=CurlImpersonateHttpClient(),
# % elif cookiecutter.http_client == 'httpx'
http_client=HttpxHttpClient(),
# % elif cookiecutter.http_client == 'impit'
http_client=ImpitHttpClient(),
# % endif
# % endblock
# % endfilter
Expand Down
2 changes: 2 additions & 0 deletions src/crawlee/project_template/{{cookiecutter.project_name}}/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
# % endif
# % if cookiecutter.http_client == 'curl-impersonate'
# % do extras.append('curl-impersonate')
# % elif cookiecutter.http_client == 'impit'
# % do extras.append('impit')
# % endif

[project]
Expand Down
1 change: 1 addition & 0 deletions tests/e2e/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ def pytest_configure(config: Config) -> None:
for marker in [
'httpx',
'curl_impersonate',
'impit',
'playwright',
'playwright_camoufox',
'parsel',
Expand Down
1 change: 1 addition & 0 deletions tests/e2e/project_template/test_static_crawlers_templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
[
pytest.param('httpx', marks=pytest.mark.httpx),
pytest.param('curl-impersonate', marks=pytest.mark.curl_impersonate),
pytest.param('impit', marks=pytest.mark.impit),
],
)
@pytest.mark.parametrize(
Expand Down
Loading