Skip to content

refactor!: Replace HttpxHttpClient with ImpitHttpClient as default HTTP client #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 25, 2025
Merged

refactor!: Replace HttpxHttpClient with ImpitHttpClient as default HTTP client #1307

merged 10 commits into from
Jul 25, 2025
+105 −91

Conversation

@Mantisus
Copy link
Collaborator

@Mantisus Mantisus commented Jul 15, 2025

Description

  • Replace HttpxHttpClient with ImpitHttpClient as default HTTP client

Issues

@Mantisus Mantisus marked this pull request as draft July 15, 2025 16:14
@Mantisus
Copy link
Collaborator Author

Mantisus commented Jul 15, 2025

The cookie issue should be resolved in the next impit release - apify/impit#213

@Mantisus Mantisus self-assigned this Jul 15, 2025
@Mantisus Mantisus mentioned this pull request Jul 21, 2025
Merged
@Mantisus Mantisus marked this pull request as ready for review July 23, 2025 16:25
vdusek
vdusek requested changes Jul 25, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few comments 🙂.

Also, what now - are we gonna switch from httpx to impit in Apify Python Client? This will result in fewer dependencies in the SDK...

  • SDK -> [Crawlee, Client]
  • Crawlee -> Impit
  • Client -> Impit

(No HTTPX in the minimal instalation.)

@Mantisus
Copy link
Collaborator Author

Mantisus commented Jul 25, 2025

Also, what now - are we gonna switch from httpx to impit in Apify Python Client? This will result in fewer dependencies in the SDK...

That makes sense. But I've now checked the client code. Before replacing httpx, we need to update the tests because we won't be able to use respx with impit

@Mantisus Mantisus requested a review from vdusek July 25, 2025 12:01
vdusek
vdusek approved these changes Jul 25, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@vdusek vdusek merged commit c803a97 into apify:master Jul 25, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pijukatel Pijukatel Pijukatel approved these changes

@vdusek vdusek vdusek approved these changes

@janbuchar janbuchar Awaiting requested review from janbuchar

Assignees

@Mantisus Mantisus

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integrate impit as HTTP client

3 participants

@Mantisus @vdusek @Pijukatel