Backport TINKERPOP-3017 Added AnonymousTraversalSource.with() to 3.8#3073
Merged
Cole-Greer merged 2 commits intoapache:3.8-devfrom Mar 17, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.8-dev #3073 +/- ##
==========================================
Coverage ? 76.37%
Complexity ? 13244
==========================================
Files ? 1062
Lines ? 61577
Branches ? 7347
==========================================
Hits ? 47031
Misses ? 12033
Partials ? 2513 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Replaces withEmbedded() and withRemote() and removes the long deprecated withGraph(). A single unified with() removes the need to check the object being given to the AnonymousTraversalSource to decide which method to use. Can't remember why that split was used in the first place. This should make it easier to explain how to use the AnonymousTraversalSource in the first place, requires a bit less typing and simply streamlines the API.
andreachild
force-pushed
the
3.8-backport-TINKERPOP-3017
branch
from
6c980d9 to
e60ccd2
Compare
Contributor
|
VOTE +1 |
Contributor
|
VOTE +1. |
Contributor
|
Merge note: when this gets merged up to master, remove the CHANGELOG and UPGRADE entries from master as they will now be included in the 3.8 sections. |
Contributor
|
Merging as CTR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-3017
Replaces withEmbedded() and withRemote() and removes the long deprecated withGraph(). A single unified with() removes the need to check the object being given to the AnonymousTraversalSource to decide which method to use. Can't remember why that split was used in the first place. This should make it easier to explain how to use the AnonymousTraversalSource in the first place, requires a bit less typing and simply streamlines the API.
This is a back port of #2366 from master (4.0).