TINKERPOP-3017 Added AnonymousTraversalSource.with()

[spmallette]

https://issues.apache.org/jira/browse/TINKERPOP-3017

Replaces withEmbedded() and withRemote() and removes the long deprecated
withGraph(). A single unified with() removes the need to check the object being given to the AnonymousTraversalSource to decide which method to use. Can't remember why that split was used in the first place. This should make it easier to explain how to use the AnonymousTraversalSource in the first place, requires a bit less typing and simply streamlines the API.

VOTE +1

[codecov-commenter]

Codecov Report

❌ Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.51%. Comparing base (e0f6ada) to head (133eb47).
⚠️ Report is 1413 commits behind head on master.

Files with missing lines	Patch %	Lines
...in/process/traversal/AnonymousTraversalSource.java	25.00%	9 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2366      +/-   ##
============================================
+ Coverage     76.17%   76.51%   +0.33%     
- Complexity    13118    13127       +9     
============================================
  Files          1083     1058      -25     
  Lines         65001    61064    -3937     
  Branches       7259     7259              
============================================
- Hits          49517    46725    -2792     
+ Misses        12788    11840     -948     
+ Partials       2696     2499     -197     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[kenhuuu]

This change makes sense to me for Java as there is no clashing of parameter types between the remote and embedded versions so this is a nice change. However, it looks a bit odd for Python since it is renamed to with_.

VOTE +1

[spmallette]

However, it looks a bit odd for Python since it is renamed to with_.

the underscore is basically part of the whole Gremlin language for python though: https://tinkerpop.apache.org/docs/current/reference/#gremlin-python-differences

[xiazcy]

VOTE +1