Backport TINKERPOP-3083 split() changes to 3.8#3072
Merged
Cole-Greer merged 1 commit intoapache:3.8-devfrom Mar 17, 2025
Merged
Backport TINKERPOP-3083 split() changes to 3.8#3072Cole-Greer merged 1 commit intoapache:3.8-devfrom
Cole-Greer merged 1 commit intoapache:3.8-devfrom
Conversation
andreachild
force-pushed
the
3.8-backport-split
branch
from
be4e9c0 to
20aa5f6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.8-dev #3072 +/- ##
==========================================
Coverage ? 76.38%
Complexity ? 13243
==========================================
Files ? 1062
Lines ? 61572
Branches ? 7347
==========================================
Hits ? 47030
Misses ? 12028
Partials ? 2514 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… StringUtil.split utility method which will split the given string into a list of individual string characters if the given separator is an empty string.
andreachild
force-pushed
the
3.8-backport-split
branch
from
75ad9c2 to
def92ea
Compare
andreachild
changed the title
Contributor
|
VOTE +1 |
1 similar comment
Contributor
|
VOTE +1 |
Contributor
|
Merging as CTR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-3083
Changed split() local and global steps to parse a string into individual characters if the separator is an empty string - previous implementation left the string intact. Introduced StringUtil utility class to reuse logic between the global and local step classes. Feature tests were executed using -DskipIntegrationTests=false and manual testing was executed using gremlin console with and without remote context.
This is a back port from master branch which is at version 4.0. Original PR: #2741