TINKERPOP-3083: The split() step should provide a way to split an entire string#2741
Merged
Cole-Greer merged 1 commit intoapache:masterfrom Aug 28, 2024
Merged
Conversation
andreachild
changed the title
andreachild
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2741 +/- ##
============================================
+ Coverage 76.16% 76.75% +0.58%
- Complexity 13170 13890 +720
============================================
Files 1085 1103 +18
Lines 65189 68249 +3060
Branches 7289 7418 +129
============================================
+ Hits 49651 52382 +2731
- Misses 12830 13147 +317
- Partials 2708 2720 +12 ☔ View full report in Codecov by Sentry. |
kenhuuu
reviewed
Aug 22, 2024
|
|
||
| * `separator` - The string character(s) used as delimiter to split the input string. Nullable, a null separator will split on | ||
| whitespaces. | ||
| whitespaces. An empty separator will split on each character. |
Contributor
There was a problem hiding this comment.
Minor nit: I think it should probably be "empty string separator"
Contributor
Author
There was a problem hiding this comment.
Changed to 'empty string separator' for this file and also the-traversal.asciidoc.
Contributor
|
Requires a CHANGELOG entry. VOTE +1 pending minor nits. Thanks for contributing. |
andreachild
force-pushed
the
TINKERPOP-3083_split
branch
from
859daaf to
f45d11a
Compare
Contributor
|
Thanks @andreachild, looks great! VOTE +1 |
… StringUtil.split utility method which will split the given string into a list of individual string characters if the given separator is an empty string.
andreachild
force-pushed
the
TINKERPOP-3083_split
branch
from
d4d1c48 to
17894b7
Compare
Contributor
|
VOTE +1, thanks @andreachild! |
This was referenced Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-3083
Changed split() local and global steps to parse a string into individual characters if the separator is an empty string - previous implementation left the string intact. Introduced StringUtil utility class to reuse logic between the global and local step classes. Feature tests were executed using
-DskipIntegrationTests=falseand manual testing was executed using gremlin console with and without remote context.