Skip to content

TEZ-4594. Tez shuffle handler should not shade and relocate javax packages #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jteagles merged 1 commit into from
Jan 16, 2025
Merged

TEZ-4594. Tez shuffle handler should not shade and relocate javax packages #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions tez-plugins/tez-aux-services/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@
<filter>
<artifact>*:*</artifact>
<excludes>
<exclude>javax/**</exclude>
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
Expand All @@ -241,15 +242,6 @@
<pattern>io.netty</pattern>
<shadedPattern>org.apache.tez.shaded.$0</shadedPattern>
</relocation>
<relocation>
<pattern>javax</pattern>
<shadedPattern>org.apache.tez.shaded.$0</shadedPattern>
<excludes>
<exclude>javax.crypto.*</exclude>
<exclude>javax.security.**</exclude>
<exclude>javax.net.**</exclude>
</excludes>
</relocation>
Copy link
Contributor

@okumin okumin Dec 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the following jars are currently relocated.

  • org/apache/tez/shaded/javax/annotation/
  • org/apache/tez/shaded/javax/xml/bind/

I guess they come from Hadoop. So, "As javax is part of the jdk:" in the ticket might not be correct. Personally, I don't have any objections to exclude javax, though

+- org.apache.hadoop:hadoop-yarn-api:jar:3.3.6:provided
|  +- javax.xml.bind:jaxb-api:jar:2.2.11:compile

Copy link
Contributor Author

@jteagles jteagles Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okumin , thanks for the clarification
@abstractdog , @okumin is there any other change needed before +1?

Copy link
Contributor

@abstractdog abstractdog Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change +1

</relocations>
</configuration>
</execution>
Expand Down
Loading