-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-52844][PYTHON] Update protobuf Python package to 5.29.5
#51747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f6ca0ee to
de5dcb0
Compare
|
@bjornjorgensen Pre your comment on #51636 I have started splitting the dependency updates |
de5dcb0 to
2fe375c
Compare
7164d66 to
a93471d
Compare
a93471d to
c693611
Compare
protobuf Python package to 5.29.5
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making a PR, @eschcam . Could you rebase once more to resolve the conflicts, please?
c693611 to
8f55c12
Compare
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM (Pending CIs).
Thank you for updating this PR, @eschcam .
|
@dongjoon-hyun is the file .github/workflows/build_python_connect35.yml for the 3.5 branch? |
Yes. It's a test pipeline to run a test from |
8f55c12 to
a554d2a
Compare
|
The compilation of Could you rebase once more? |
a554d2a to
5d475ed
Compare
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @eschcam and all. Merged to master.
Since 4.1.0-preview2 RC1 vote started already, this will be a part of 4.1.0-preview3 at the end of October.
|
Oh, @eschcam . You should not reuse the JIRA ID like this. This screwed the trace-ability of Apache Spark community. |
Ahh. I'll keep that in mind going forward |
What changes were proposed in this pull request?
Updating protobuf from 5.29.1 to 5.29.5
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
Passed all CI tests
Was this patch authored or co-authored using generative AI tooling?
No