Skip to content

Conversation

@eschcam
Copy link
Contributor

@eschcam eschcam commented Jul 31, 2025

What changes were proposed in this pull request?

Updating protobuf from 5.29.1 to 5.29.5

Why are the changes needed?

Does this PR introduce any user-facing change?

No

How was this patch tested?

Passed all CI tests

Was this patch authored or co-authored using generative AI tooling?

No

@eschcam
Copy link
Contributor Author

eschcam commented Aug 12, 2025

@bjornjorgensen Pre your comment on #51636 I have started splitting the dependency updates

@eschcam eschcam force-pushed the py-protobuf-update branch from de5dcb0 to 2fe375c Compare August 14, 2025 09:58
@eschcam eschcam force-pushed the py-protobuf-update branch from 7164d66 to a93471d Compare August 15, 2025 11:21
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-52844][PYTHON] Update protobuf to 5.29.5 [SPARK-52844][PYTHON] Update protobuf Python package to 5.29.5 Sep 22, 2025
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making a PR, @eschcam . Could you rebase once more to resolve the conflicts, please?

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CIs).

Thank you for updating this PR, @eschcam .

@bjornjorgensen
Copy link
Contributor

@dongjoon-hyun is the file ‎.github/workflows/build_python_connect35.yml for the 3.5 branch?

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun is the file ‎.github/workflows/build_python_connect35.yml for the 3.5 branch?

Yes. It's a test pipeline to run a test from branch-3.5-client (Spark 3.5.7-SNAPSHOT) on Python 3.11 against master (Spark 4.1.0-SNAPSHOT).

@dongjoon-hyun
Copy link
Member

The compilation of master branch was broken accidentally 3 hours ago and now it's fixed at 1841dd2 .

Could you rebase once more?

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @eschcam and all. Merged to master.

Since 4.1.0-preview2 RC1 vote started already, this will be a part of 4.1.0-preview3 at the end of October.

@dongjoon-hyun
Copy link
Member

Oh, @eschcam . You should not reuse the JIRA ID like this. This screwed the trace-ability of Apache Spark community.

$ git log --oneline | grep SPARK-52844
ed326b2d13c [SPARK-52844][PYTHON] Update `protobuf` Python package to 5.29.5
43f650eaa43 [SPARK-52844][PYTHON] Update numpy to 1.22

@eschcam
Copy link
Contributor Author

eschcam commented Sep 25, 2025

Oh, @eschcam . You should not reuse the JIRA ID like this. This screwed the trace-ability of Apache Spark community.

$ git log --oneline | grep SPARK-52844
ed326b2d13c [SPARK-52844][PYTHON] Update `protobuf` Python package to 5.29.5
43f650eaa43 [SPARK-52844][PYTHON] Update numpy to 1.22

Ahh. I'll keep that in mind going forward

@eschcam eschcam deleted the py-protobuf-update branch September 29, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants