[SPARK-34317][SQL][FOLLOW-UP] Use relationTypeMismatchHint when UnresolvedTable is resolved to a temp view #31452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imback82
commented
Feb 3, 2021
| s"$quoted as it's not a data source v2 relation.") | ||
| } | ||
|
|
||
| def expectTableNotTempViewError(quoted: String, cmd: String, t: TreeNode[_]): Throwable = { |
Contributor
Author
There was a problem hiding this comment.
We can just reuse expectTableNotViewError if we pass ResolvedView.
cloud-fan
approved these changes
Feb 3, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #134813 has finished for PR 31452 at commit
|
Contributor
|
thanks, merging to master! |
skestle
pushed a commit
to skestle/spark
that referenced
this pull request
Feb 3, 2021
…olvedTable is resolved to a temp view ### What changes were proposed in this pull request? This is a follow up to apache#31424, and proposes to use `UnresolvedTable.relationTypeMismatchHint` when `UnresolvedTable` is resolved to a temp view. ### Why are the changes needed? This change utilizes the type mismatch hint when a relation is resolved to a temp view when a table is expected. For example, `ALTER TABLE tmpView SET TBLPROPERTIES ('p' = 'an')` will now include `Please use ALTER VIEW instead.` in the exception message: `tmpView is a temp view. 'ALTER TABLE ... SET TBLPROPERTIES' expects a table. Please use ALTER VIEW instead.` ### Does this PR introduce _any_ user-facing change? Yes, adds the hint in the exception message. ### How was this patch tested? Update existing tests to include the hint. Closes apache#31452 from imback82/followup_SPARK-34317. Authored-by: Terry Kim <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow up to #31424, and proposes to use
UnresolvedTable.relationTypeMismatchHintwhenUnresolvedTableis resolved to a temp view.Why are the changes needed?
This change utilizes the type mismatch hint when a relation is resolved to a temp view when a table is expected.
For example,
ALTER TABLE tmpView SET TBLPROPERTIES ('p' = 'an')will now includePlease use ALTER VIEW instead.in the exception message:tmpView is a temp view. 'ALTER TABLE ... SET TBLPROPERTIES' expects a table. Please use ALTER VIEW instead.Does this PR introduce any user-facing change?
Yes, adds the hint in the exception message.
How was this patch tested?
Update existing tests to include the hint.