[SPARK-34317][SQL] Introduce relationTypeMismatchHint to UnresolvedTable for a better error message #31424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
Contributor
Author
|
Test build #134745 has finished for PR 31424 at commit
|
cloud-fan
approved these changes
Feb 2, 2021
Contributor
|
thanks, merging to master! |
imback82
commented
Feb 3, 2021
| case u @ UnresolvedTable(identifier, cmd, relationTypeMismatchHint) => | ||
| lookupTableOrView(identifier).map { | ||
| case v: ResolvedView => throw QueryCompilationErrors.expectTableNotViewError(v, cmd, u) | ||
| case v: ResolvedView => |
Contributor
Author
There was a problem hiding this comment.
@cloud-fan looks like I missed handling this in ResolveTempViews. I will create a follow up PR. Sorry about that.
cloud-fan
pushed a commit
that referenced
this pull request
Feb 3, 2021
…olvedTable is resolved to a temp view ### What changes were proposed in this pull request? This is a follow up to #31424, and proposes to use `UnresolvedTable.relationTypeMismatchHint` when `UnresolvedTable` is resolved to a temp view. ### Why are the changes needed? This change utilizes the type mismatch hint when a relation is resolved to a temp view when a table is expected. For example, `ALTER TABLE tmpView SET TBLPROPERTIES ('p' = 'an')` will now include `Please use ALTER VIEW instead.` in the exception message: `tmpView is a temp view. 'ALTER TABLE ... SET TBLPROPERTIES' expects a table. Please use ALTER VIEW instead.` ### Does this PR introduce _any_ user-facing change? Yes, adds the hint in the exception message. ### How was this patch tested? Update existing tests to include the hint. Closes #31452 from imback82/followup_SPARK-34317. Authored-by: Terry Kim <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
skestle
pushed a commit
to skestle/spark
that referenced
this pull request
Feb 3, 2021
…ble for a better error message ### What changes were proposed in this pull request? This PR proposes to add `relationTypeMismatchHint` to `UnresolvedTable` so that if a relation is resolved to a view when a table is expected, a hint message can be included as a part of the analysis exception message. Note that the same feature is already introduced to `UnresolvedView` in apache#30636. This mostly affects `ALTER TABLE` commands where the analysis exception message will now contain `Please use ALTER VIEW as instead`. ### Why are the changes needed? To give a better error message. (The hint used to exist but got removed for commands that migrated to the new resolution framework) ### Does this PR introduce _any_ user-facing change? Yes, now `ALTER TABLE` commands include a hint to use `ALTER VIEW` instead. ``` sql("ALTER TABLE v SET SERDE 'whatever'") ``` Before: ``` "v is a view. 'ALTER TABLE ... SET [SERDE|SERDEPROPERTIES]' expects a table. ``` After this PR: ``` "v is a view. 'ALTER TABLE ... SET [SERDE|SERDEPROPERTIES]' expects a table. Please use ALTER VIEW instead. ``` ### How was this patch tested? Updated existing test cases to include the hint. Closes apache#31424 from imback82/better_error. Authored-by: Terry Kim <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
skestle
pushed a commit
to skestle/spark
that referenced
this pull request
Feb 3, 2021
…olvedTable is resolved to a temp view ### What changes were proposed in this pull request? This is a follow up to apache#31424, and proposes to use `UnresolvedTable.relationTypeMismatchHint` when `UnresolvedTable` is resolved to a temp view. ### Why are the changes needed? This change utilizes the type mismatch hint when a relation is resolved to a temp view when a table is expected. For example, `ALTER TABLE tmpView SET TBLPROPERTIES ('p' = 'an')` will now include `Please use ALTER VIEW instead.` in the exception message: `tmpView is a temp view. 'ALTER TABLE ... SET TBLPROPERTIES' expects a table. Please use ALTER VIEW instead.` ### Does this PR introduce _any_ user-facing change? Yes, adds the hint in the exception message. ### How was this patch tested? Update existing tests to include the hint. Closes apache#31452 from imback82/followup_SPARK-34317. Authored-by: Terry Kim <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add
relationTypeMismatchHinttoUnresolvedTableso that if a relation is resolved to a view when a table is expected, a hint message can be included as a part of the analysis exception message. Note that the same feature is already introduced toUnresolvedViewin #30636.This mostly affects
ALTER TABLEcommands where the analysis exception message will now containPlease use ALTER VIEW as instead.Why are the changes needed?
To give a better error message. (The hint used to exist but got removed for commands that migrated to the new resolution framework)
Does this PR introduce any user-facing change?
Yes, now
ALTER TABLEcommands include a hint to useALTER VIEWinstead.Before:
After this PR:
How was this patch tested?
Updated existing test cases to include the hint.