Skip to content

Conversation

@shaneknapp
Copy link
Contributor

What changes were proposed in this pull request?

remove python 3.8 from python/run-tests.py and stop build breaks

Why are the changes needed?

the python tests are running against the bare-bones system install of python3, rather than an anaconda environment.

Does this PR introduce any user-facing change?

no

How was this patch tested?

jenkins

see also #30506

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@dongjoon-hyun
Copy link
Member

BTW, @shaneknapp .
We can have python3.8 at Ubuntu 20.04 with package python3.8. What about installing Python3.8?

@shaneknapp
Copy link
Contributor Author

BTW, @shaneknapp .
We can have python3.8 at Ubuntu 20.04 with package python3.8. What about installing Python3.8?

right now, i have to finish porting everything, including the master node, to ubuntu20. then in a ~month, reinstall all the old ubuntu 16 workers. during this time we'll also get through the backlog of outstanding package reqs, as well as setting up a py38 environment.

@dongjoon-hyun
Copy link
Member

Got it. No problem~

@SparkQA
Copy link

SparkQA commented Nov 25, 2020

Test build #131814 has finished for PR 30509 at commit 7695f29.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

shaneknapp added a commit that referenced this pull request Nov 25, 2020
### What changes were proposed in this pull request?
remove python 3.8 from python/run-tests.py and stop build breaks

### Why are the changes needed?
the python tests are running against the bare-bones system install of python3, rather than an anaconda environment.

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
jenkins

see also #30506

Closes #30509 from shaneknapp/remove-py38-spark3.

Authored-by: shane knapp <[email protected]>
Signed-off-by: shane knapp <[email protected]>
@shaneknapp
Copy link
Contributor Author

hmm, well this didn't get autoclosed for some reason. closing manually. it's merged in to 3.0...

@shaneknapp shaneknapp closed this Nov 25, 2020
@AmplabJenkins
Copy link

Build finished.

1 similar comment
@AmplabJenkins
Copy link

Build finished.

@AmplabJenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36413/

@AmplabJenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131814/

@HyukjinKwon
Copy link
Member

LGTM. Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants