-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-33565][BUILD][PYTHON] remove python3.8 and fix breakage #30506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #131812 has finished for PR 30506 at commit
|
|
@HyukjinKwon @dongjoon-hyun look good? i'll merge as soon as you think we're good to go |
|
Build finished. |
|
Refer to this link for build results (access rights to CI server needed): |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
Are we going to add back Python 3.8 later?
|
yes, next year when we have time. |
### What changes were proposed in this pull request? remove python 3.8 from python/run-tests.py and stop build breaks ### Why are the changes needed? the python tests are running against the bare-bones system install of python3, rather than an anaconda environment. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? jenkins see also #30506 Closes #30509 from shaneknapp/remove-py38-spark3. Authored-by: shane knapp <[email protected]> Signed-off-by: shane knapp <[email protected]>
|
Build finished. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Yeah, LGTM to recover the build for now. However, we should bring it back soon. Python 3.8 was being tested in GitHub Actions but they are not tested anymore after this change. |
What changes were proposed in this pull request?
remove python 3.8 from python/run-tests.py and stop build breaks
Why are the changes needed?
the python tests are running against the bare-bones system install of python3, rather than an anaconda environment.
Does this PR introduce any user-facing change?
no
How was this patch tested?
via jenkins