Skip to content

Conversation

@shaneknapp
Copy link
Contributor

What changes were proposed in this pull request?

remove python 3.8 from python/run-tests.py and stop build breaks

Why are the changes needed?

the python tests are running against the bare-bones system install of python3, rather than an anaconda environment.

Does this PR introduce any user-facing change?

no

How was this patch tested?

via jenkins

@SparkQA
Copy link

SparkQA commented Nov 25, 2020

Test build #131812 has finished for PR 30506 at commit 986feb6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shaneknapp
Copy link
Contributor Author

@HyukjinKwon @dongjoon-hyun look good? i'll merge as soon as you think we're good to go

@AmplabJenkins
Copy link

Build finished.

@AmplabJenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131812/

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

Are we going to add back Python 3.8 later?

@shaneknapp
Copy link
Contributor Author

yes, next year when we have time.

shaneknapp added a commit that referenced this pull request Nov 25, 2020
### What changes were proposed in this pull request?
remove python 3.8 from python/run-tests.py and stop build breaks

### Why are the changes needed?
the python tests are running against the bare-bones system install of python3, rather than an anaconda environment.

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
jenkins

see also #30506

Closes #30509 from shaneknapp/remove-py38-spark3.

Authored-by: shane knapp <[email protected]>
Signed-off-by: shane knapp <[email protected]>
@AmplabJenkins
Copy link

Build finished.

@AmplabJenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36411/

@HyukjinKwon
Copy link
Member

Yeah, LGTM to recover the build for now. However, we should bring it back soon. Python 3.8 was being tested in GitHub Actions but they are not tested anymore after this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants