[MINOR][DOC] Fix document UI left menu broken #27479
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test build #117999 has finished for PR 27479 at commit
|
Member
|
Thank you for fixing this, @xuanyuanking . |
dongjoon-hyun
approved these changes
Feb 6, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. I verified this with Ruby 2.7.0.
Merged to master/3.0.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 6, 2020
### What changes were proposed in this pull request? Fix the left menu broken introduced in #25459. ### Why are the changes needed? The `left-menu-wrapper` CSS reused for both ml-guide and sql-programming-guide, the before changes will break the UI. Before:    After:    ### Does this PR introduce any user-facing change? Document UI change only. ### How was this patch tested? Local test, screenshot attached below. Closes #27479 from xuanyuanking/doc-ui. Authored-by: Yuanjian Li <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 4804445) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
|
Thanks for the quick review and verification. |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
### What changes were proposed in this pull request? Fix the left menu broken introduced in apache#25459. ### Why are the changes needed? The `left-menu-wrapper` CSS reused for both ml-guide and sql-programming-guide, the before changes will break the UI. Before:    After:    ### Does this PR introduce any user-facing change? Document UI change only. ### How was this patch tested? Local test, screenshot attached below. Closes apache#27479 from xuanyuanking/doc-ui. Authored-by: Yuanjian Li <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the left menu broken introduced in #25459.
Why are the changes needed?
The
left-menu-wrapperCSS reused for both ml-guide and sql-programming-guide, the before changes will break the UI.Before:
After:
Does this PR introduce any user-facing change?
Document UI change only.
How was this patch tested?
Local test, screenshot attached below.