[SPARK-28734][DOC] Initial table of content in the left hand side bar for SQL doc #25459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @gatorsmile |
|
Test build #109141 has finished for PR 25459 at commit
|
Member
|
@dilipbiswal Could you copy and paste the WebUI pages [before and after your changes] |
Contributor
Author
|
@gatorsmile This is after change.. I have not captured all the screen shots..
|
Contributor
Author
|
@gatorsmile This is before .. |
gatorsmile
changed the title
gatorsmile
reviewed
Aug 19, 2019
| url: sql-ref-syntax-ddl.html | ||
| subitems: | ||
| - text: ALTER DATABASE | ||
| url: sql-ref-syntax-ddl-alter-database.html |
Member
There was a problem hiding this comment.
Could you create sub tasks for each page?
Contributor
Author
There was a problem hiding this comment.
@gatorsmile Sure.. I will create the sub tasks tomorrow.
Member
|
LGTM. We will remove the incomplete pages if we are unable to finish them before the release. Thanks! Merged to master. |
Contributor
Author
|
Thank you very much @gatorsmile |
dbtsai
pushed a commit
to dbtsai/spark
that referenced
this pull request
Feb 6, 2020
### What changes were proposed in this pull request? Fix the left menu broken introduced in apache#25459. ### Why are the changes needed? The `left-menu-wrapper` CSS reused for both ml-guide and sql-programming-guide, the before changes will break the UI. Before:    After:    ### Does this PR introduce any user-facing change? Document UI change only. ### How was this patch tested? Local test, screenshot attached below. Closes apache#27479 from xuanyuanking/doc-ui. Authored-by: Yuanjian Li <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 6, 2020
### What changes were proposed in this pull request? Fix the left menu broken introduced in #25459. ### Why are the changes needed? The `left-menu-wrapper` CSS reused for both ml-guide and sql-programming-guide, the before changes will break the UI. Before:    After:    ### Does this PR introduce any user-facing change? Document UI change only. ### How was this patch tested? Local test, screenshot attached below. Closes #27479 from xuanyuanking/doc-ui. Authored-by: Yuanjian Li <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 4804445) Signed-off-by: Dongjoon Hyun <[email protected]>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
### What changes were proposed in this pull request? Fix the left menu broken introduced in apache#25459. ### Why are the changes needed? The `left-menu-wrapper` CSS reused for both ml-guide and sql-programming-guide, the before changes will break the UI. Before:    After:    ### Does this PR introduce any user-facing change? Document UI change only. ### How was this patch tested? Local test, screenshot attached below. Closes apache#27479 from xuanyuanking/doc-ui. Authored-by: Yuanjian Li <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
HyukjinKwon
reviewed
Nov 12, 2020
| .left-menu { | ||
| padding: 0px; | ||
| width: 199px; | ||
| width: 399px; |
Member
There was a problem hiding this comment.
Sorry for leaving a comment in an old PR but @dilipbiswal do you remember why you had to do this? It
This makes each title look sort of truncated. I was thinking it should be like:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a initial PR that creates the table of content for SQL reference guide. The left side bar will displays additional menu items corresponding to supported SQL constructs. One this PR is merged, we will fill in the content incrementally. Additionally this PR contains a minor change to make the left sidebar scrollable. Currently it is not possible to scroll in the left hand side window.
How was this patch tested?
Used jekyll build and serve to verify.