Skip to content

[SPARK-23356][SQL][TEST] add new test cases for a + 1,a + b and Rand in SetOperationSuite #23138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
heary-cao wants to merge 1 commit into from
Closed

[SPARK-23356][SQL][TEST] add new test cases for a + 1,a + b and Rand in SetOperationSuite #23138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SetOperationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ package org.apache.spark.sql.catalyst.optimizer
import org.apache.spark.sql.catalyst.analysis.EliminateSubqueryAliases
import org.apache.spark.sql.catalyst.dsl.expressions._
import org.apache.spark.sql.catalyst.dsl.plans._
import org.apache.spark.sql.catalyst.expressions.{Alias, And, GreaterThan, GreaterThanOrEqual, If, Literal, ReplicateRows}
import org.apache.spark.sql.catalyst.expressions.{And, GreaterThan, GreaterThanOrEqual, If, Literal, Rand, ReplicateRows}
import org.apache.spark.sql.catalyst.plans.PlanTest
import org.apache.spark.sql.catalyst.plans.logical._
import org.apache.spark.sql.catalyst.rules._
Expand Down Expand Up @@ -196,4 +196,31 @@ class SetOperationSuite extends PlanTest {
))
comparePlans(expectedPlan, rewrittenPlan)
}

test("SPARK-23356 union: expressions with literal in project list are pushed down") {
val unionQuery = testUnion.select(('a + 1).as("aa"))
val unionOptimized = Optimize.execute(unionQuery.analyze)
val unionCorrectAnswer =
Union(testRelation.select(('a + 1).as("aa")) ::
testRelation2.select(('d + 1).as("aa")) ::
testRelation3.select(('g + 1).as("aa")) :: Nil).analyze
comparePlans(unionOptimized, unionCorrectAnswer)
}

test("SPARK-23356 union: expressions in project list are pushed down") {
val unionQuery = testUnion.select(('a + 'b).as("ab"))
val unionOptimized = Optimize.execute(unionQuery.analyze)
val unionCorrectAnswer =
Union(testRelation.select(('a + 'b).as("ab")) ::
testRelation2.select(('d + 'e).as("ab")) ::
testRelation3.select(('g + 'h).as("ab")) :: Nil).analyze
comparePlans(unionOptimized, unionCorrectAnswer)
}

test("SPARK-23356 union: no pushdown for non-deterministic expression") {
val unionQuery = testUnion.select('a, Rand(10).as("rnd"))
val unionOptimized = Optimize.execute(unionQuery.analyze)
val unionCorrectAnswer = unionQuery.analyze
comparePlans(unionOptimized, unionCorrectAnswer)
}
}